<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.hoenzb
{mso-style-name:hoenzb;}
span.im
{mso-style-name:im;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Daniel, we’ve resolved this in patch v2.<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> Daniel Stone [mailto:daniel@fooishbar.org]
<br>
<b>Sent:</b> Wednesday, October 29, 2014 0:56<br>
<b>To:</b> Jiang, Fei<br>
<b>Cc:</b> Emil Velikov; Cheng, Yao; intel-gfx@lists.freedesktop.org; Vetter, Daniel; dri-devel@lists.freedesktop.org<br>
<b>Subject:</b> Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Hi,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 17 October 2014 01:36, Jiang, Fei <<a href="mailto:fei.jiang@intel.com" target="_blank">fei.jiang@intel.com</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Thanks for Emil's suggestion. You are right, we need make sure structure size aligned on 8 bytes, which is important for 32bit-64bit compatible case.<o:p></o:p></p>
</blockquote>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">While you're at it, please don't use enum as a type inside ioctls, since the size can vary by compiler. Please use a uint32_t or whatever instead, assigning enum values to that.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"> <span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal">Cheers,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Daniel<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><span class="hoenzb"><span style="color:#888888">Fei</span></span><span style="color:#888888"><br>
</span><span class="im">-----Original Message-----</span><br>
<span class="im">From: Emil Velikov [mailto:<a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>]</span><o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">Sent: Thursday, October 16, 2014 11:20 PM<br>
To: Cheng, Yao; <a href="mailto:intel-gfx@lists.freedesktop.org">intel-gfx@lists.freedesktop.org</a><br>
Cc: <a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>; Jiang, Fei;
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a>; Vetter, Daniel<br>
Subject: Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm driver<br>
<br>
On 16/10/14 15:33, Cheng, Yao wrote:<br>
> Hi Emil,<br>
> Sorry, what do you mean by "correctly aligned"? does it mean the paddings in this data structure?<br>
><br>
Afaict for compatibility reasons the struct size have to be "aligned"<br>
(multiple of 8 bytes), or if you prefer - the struct is missing the required padding :) I've only skimmed through the patch so it may be that other structs are having this issue.<br>
<br>
Cheers,<br>
Emil<br>
<br>
>> -----Original Message-----<br>
>> From: Emil Velikov [mailto:<a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>]<br>
>> Sent: Wednesday, October 15, 2014 5:24 PM<br>
>> To: Cheng, Yao; <a href="mailto:intel-gfx@lists.freedesktop.org">intel-gfx@lists.freedesktop.org</a><br>
>> Cc: <a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>; Jiang, Fei;<br>
>> <a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a>; Vetter, Daniel<br>
>> Subject: Re: [RFC PATCH 3/3] libdrm: user mode helper for ipvr drm<br>
>> driver<br>
>><br>
>> Hi Yao,<br>
>><br>
>> struct drm_ipvr_gem_userptr does not seem to be correctly aligned -<br>
>> is that intentional ? Might be worth checking if anything else in<br>
>> ipvr_drm.h and ipvr_bufmgr.h is in the same boat.<br>
>><br>
>> Cheers,<br>
>> Emil<br>
>><br>
<br>
_______________________________________________<br>
dri-devel mailing list<br>
<a href="mailto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/dri-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/dri-devel</a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>