<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 13/02/2015 12:17, Chris Wilson wrote:<br>
<blockquote
cite="mid:20150213121701.GK2749@nuc-i3427.alporthouse.com"
type="cite">
<pre wrap="">On Fri, Feb 13, 2015 at 11:48:58AM +0000, <a class="moz-txt-link-abbreviated" href="mailto:John.C.Harrison@Intel.com">John.C.Harrison@Intel.com</a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">From: John Harrison <a class="moz-txt-link-rfc2396E" href="mailto:John.C.Harrison@Intel.com"><John.C.Harrison@Intel.com></a>
Now that everything above has been converted to use requests,
intel_logical_ring_begin() can be updated to take a request instead of a
ringbuf/context pair. This also means that it no longer needs to lazily allocate
a request if no-one happens to have done it earlier.
Note that this change makes the execlist signature the same as the legacy
version. Thus the two functions could be merged into a ring->begin() wrapper if
required.
</pre>
</blockquote>
<pre wrap="">
It should be noted that you don't even need to virtualise the
function... Please kill all the duplicated code.
-Chris
</pre>
</blockquote>
As noted in the cover letter, quite a lot of the execlist vs legacy
duplication could be resolved back to a single code path. However,
that was quite a large <strike>war</strike> discussion first time
around. So I would rather leave that for another patch series once
people actually decide what the best direction really is.<br>
<br>
</body>
</html>