<html> <head> <meta content="text/html; charset=windows-1252" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> <div class="moz-cite-prefix">On 5/28/2015 4:39 PM, Chris Wilson wrote:<br> </div> <blockquote cite="mid:20150528153912.GE19710@nuc-i3427.alporthouse.com" type="cite"> <pre wrap="">On Thu, May 28, 2015 at 04:24:47PM +0100, Michel Thierry wrote: </pre> <blockquote type="cite"> <pre wrap="">We already set this limit for the GGTT. This is a temporary patch until a full replacement of size_t variables (inadequate in 32-bit kernel) is in place. Regression from: commit a4e0bedca678c81eea4cd79a4bd502335639f73a Author: Michel Thierry <a class="moz-txt-link-rfc2396E" href="mailto:michel.thierry@intel.com"><michel.thierry@intel.com></a> Date: Wed Apr 8 12:13:35 2015 +0100 drm/i915: Use complete address space in true PPGTT Suggested-by: Daniel Vetter <a class="moz-txt-link-rfc2396E" href="mailto:daniel.vetter@ffwll.ch"><daniel.vetter@ffwll.ch></a> Cc: Mika Kuoppala <a class="moz-txt-link-rfc2396E" href="mailto:mika.kuoppala@intel.com"><mika.kuoppala@intel.com></a> Signed-off-by: Michel Thierry <a class="moz-txt-link-rfc2396E" href="mailto:michel.thierry@intel.com"><michel.thierry@intel.com></a> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 17b7df0..ffecb87 100644 --- a/drivers/gpu/drm/i915/i915_gem_gtt.c +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c @@ -951,7 +951,15 @@ static int gen8_ppgtt_init(struct i915_hw_ppgtt *ppgtt) gen8_initialize_pd(&ppgtt->base, ppgtt->scratch_pd); ppgtt->base.start = 0; + +#ifdef CONFIG_X86_32 + /* Limit 32b platforms to GGTT size (2GB) */ </pre> </blockquote> <pre wrap=""> Forgot the comment about why the limit is inplace and when it can be lifted. Remember comments are for *why* not *what*. </pre> <blockquote type="cite"> <pre wrap="">+ struct drm_i915_private *dev_priv = ppgtt->base.dev->dev_private; </pre> </blockquote> <pre wrap=""> Fancy new fangled C. </pre> <blockquote type="cite"> <pre wrap="">+ ppgtt->base.total = dev_priv->gtt.base.total; </pre> </blockquote> <pre wrap=""> ppgtt->base.total = to_i915(ppgtt->base.dev)->gtt.base.total; </pre> <blockquote type="cite"> <pre wrap="">+#else ppgtt->base.total = 1ULL << 32; +#endif </pre> </blockquote> <pre wrap=""> Better yet would be: ppgtt->base.total = 1ULL << 32; if (IS_ENABLED(CONFIG_X86_32)) { /* While we have a proliferation of size_t variables * we cannot represent the full ppgtt size on 32bit, * so limit it to the same size as the GGTT (currently * 2GiB). */ ppgtt->base.total = to_i915(ppgtt->base.dev)->gtt.base.total; } However, I am afraid that it will become obsolete but be forgotten to be removed.</pre> </blockquote> Yes, this is just for 4.2, Mika started working on a patch to replace the size_t variables.<br> I'll update this with your changes.<br> <br> Thanks,<br> <br> <meta name="ProgId" content="Word.Document"> <meta name="Generator" content="Microsoft Word 14"> <meta name="Originator" content="Microsoft Word 14"> <link rel="File-List" href="file:///C:%5CUsers%5Cmichelth%5CAppData%5CLocal%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_filelist.xml">  <link rel="themeData" href="file:///C:%5CUsers%5Cmichelth%5CAppData%5CLocal%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_themedata.thmx"> <link rel="colorSchemeMapping" href="file:///C:%5CUsers%5Cmichelth%5CAppData%5CLocal%5CTemp%5Cmsohtmlclip1%5C01%5Cclip_colorschememapping.xml">  <style>  </style> <blockquote cite="mid:20150528153912.GE19710@nuc-i3427.alporthouse.com" type="cite"> <pre wrap=""> -Chris </pre> </blockquote> </body> </html>