<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 14, 2015 at 12:30 PM Paulo Zanoni <<a href="mailto:przanoni@gmail.com">przanoni@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Paulo Zanoni <<a href="mailto:paulo.r.zanoni@intel.com" target="_blank">paulo.r.zanoni@intel.com</a>><br>
<br>
Because intel_unpin_work_fn() already calls<br>
intel_frontbuffer_flip_complete() which will call intel_fbc_flush()<br>
which will call intel_fbc_update() when needed.<br>
<br>
We couldn't fix this previously due to the fact that FBC was not<br>
properly behaving as intended on frontbuffer flushes, but now that<br>
this is fixed, we can remove the additional call.<br>
<br>
Signed-off-by: Paulo Zanoni <<a href="mailto:paulo.r.zanoni@intel.com" target="_blank">paulo.r.zanoni@intel.com</a>><br>
---<br>
drivers/gpu/drm/i915/intel_display.c | 3 ---<br>
1 file changed, 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c<br>
index ad0fc6a..37b2528 100644<br>
--- a/drivers/gpu/drm/i915/intel_display.c<br>
+++ b/drivers/gpu/drm/i915/intel_display.c<br>
@@ -10765,15 +10765,12 @@ static void intel_unpin_work_fn(struct work_struct *__work)<br>
container_of(__work, struct intel_unpin_work, work);<br>
struct intel_crtc *crtc = to_intel_crtc(work->crtc);<br>
struct drm_device *dev = crtc->base.dev;<br>
- struct drm_i915_private *dev_priv = dev->dev_private;<br>
struct drm_plane *primary = crtc->base.primary;<br>
<br>
mutex_lock(&dev->struct_mutex);<br>
intel_unpin_fb_obj(work->old_fb, primary->state);<br>
drm_gem_object_unreference(&work->pending_flip_obj->base);<br>
<br>
- intel_fbc_update(dev_priv);<br></blockquote><div><br></div><div>\o/ let's kill it!</div><div><br></div><div>Reviewed-by: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
-<br>
if (work->flip_queued_req)<br>
i915_gem_request_assign(&work->flip_queued_req, NULL);<br>
mutex_unlock(&dev->struct_mutex);<br>
--<br>
2.1.4<br>
<br>
_______________________________________________<br>
Intel-gfx mailing list<br>
<a href="mailto:Intel-gfx@lists.freedesktop.org" target="_blank">Intel-gfx@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
</blockquote></div></div>