<div dir="ltr"><br><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 4, 2015 at 6:37 AM Sonika Jindal <<a href="mailto:sonika.jindal@intel.com">sonika.jindal@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This is to allow live status check for HDMI as well.<br>
Also, using intel_encoder->hpd_pin to check the live status<br>
for bxt because of BXT A0/A1 WA for HPD pins.<br></blockquote><div><br></div><div>This is actually the only thing this patch does... So please use separated patch for this.... </div><div><br></div><div>But the global intel_digital_port connected can be done in the same patch that uses it actually...</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Signed-off-by: Sonika Jindal <<a href="mailto:sonika.jindal@intel.com" target="_blank">sonika.jindal@intel.com</a>><br>
---<br>
 drivers/gpu/drm/i915/intel_dp.c  |   11 +++++++----<br>
 drivers/gpu/drm/i915/intel_drv.h |    2 ++<br>
 2 files changed, 9 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c<br>
index 796f930..fedf6d1 100644<br>
--- a/drivers/gpu/drm/i915/intel_dp.c<br>
+++ b/drivers/gpu/drm/i915/intel_dp.c<br>
@@ -4663,11 +4663,14 @@ static bool vlv_digital_port_connected(struct drm_i915_private *dev_priv,<br>
 }<br>
<br>
 static bool bxt_digital_port_connected(struct drm_i915_private *dev_priv,<br>
-                                      struct intel_digital_port *port)<br>
+                                      struct intel_digital_port *intel_dig_port)<br>
 {<br>
+       struct intel_encoder *intel_encoder = &intel_dig_port->base;<br>
+       enum port port;<br>
        u32 bit;<br>
<br>
-       switch (port->port) {<br>
+       intel_hpd_pin_to_port(intel_encoder->hpd_pin, &port);<br>
+       switch (port) {<br>
        case PORT_A:<br>
                bit = BXT_DE_PORT_HP_DDIA;<br>
                break;<br>
@@ -4678,7 +4681,7 @@ static bool bxt_digital_port_connected(struct drm_i915_private *dev_priv,<br>
                bit = BXT_DE_PORT_HP_DDIC;<br>
                break;<br>
        default:<br>
-               MISSING_CASE(port->port);<br>
+               MISSING_CASE(port);<br>
                return false;<br>
        }<br>
<br>
@@ -4692,7 +4695,7 @@ static bool bxt_digital_port_connected(struct drm_i915_private *dev_priv,<br>
  *<br>
  * Return %true if @port is connected, %false otherwise.<br>
  */<br>
-static bool intel_digital_port_connected(struct drm_i915_private *dev_priv,<br>
+bool intel_digital_port_connected(struct drm_i915_private *dev_priv,<br>
                                         struct intel_digital_port *port)<br>
 {<br>
        if (HAS_PCH_IBX(dev_priv))<br>
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h<br>
index b6c2c20..ac6d748 100644<br>
--- a/drivers/gpu/drm/i915/intel_drv.h<br>
+++ b/drivers/gpu/drm/i915/intel_drv.h<br>
@@ -1210,6 +1210,8 @@ void intel_edp_drrs_disable(struct intel_dp *intel_dp);<br>
 void intel_edp_drrs_invalidate(struct drm_device *dev,<br>
                unsigned frontbuffer_bits);<br>
 void intel_edp_drrs_flush(struct drm_device *dev, unsigned frontbuffer_bits);<br>
+bool intel_digital_port_connected(struct drm_i915_private *dev_priv,<br>
+                                        struct intel_digital_port *port);<br>
<br>
 /* intel_dp_mst.c */<br>
 int intel_dp_mst_encoder_init(struct intel_digital_port *intel_dig_port, int conn_id);<br>
--<br>
1.7.10.4<br>
<br>
_______________________________________________<br>
Intel-gfx mailing list<br>
<a href="mailto:Intel-gfx@lists.freedesktop.org" target="_blank">Intel-gfx@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
</blockquote></div></div>