<div dir="ltr"><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 11, 2015 at 4:40 AM Sonika Jindal <<a href="mailto:sonika.jindal@intel.com">sonika.jindal@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Using intel_encoder's hpd_pin to check the live status<br>
because of BXT A0/A1 WA for HPD pins and hpd_pin contains the<br>
updated pin for the corresponding port.<br></blockquote><div><br></div><div>It makes sense, but is it always true? or we should have a fallback to intel_dig_port->port in some case or in some stepping after A0/A1?</div><div><br></div><div>With this clarified feel free to use:</div><div>Reviewed-by: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Signed-off-by: Sonika Jindal <<a href="mailto:sonika.jindal@intel.com" target="_blank">sonika.jindal@intel.com</a>><br>
---<br>
drivers/gpu/drm/i915/intel_dp.c | 9 ++++++---<br>
1 file changed, 6 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c<br>
index 796f930..bf17030 100644<br>
--- a/drivers/gpu/drm/i915/intel_dp.c<br>
+++ b/drivers/gpu/drm/i915/intel_dp.c<br>
@@ -4663,11 +4663,14 @@ static bool vlv_digital_port_connected(struct drm_i915_private *dev_priv,<br>
}<br>
<br>
static bool bxt_digital_port_connected(struct drm_i915_private *dev_priv,<br>
- struct intel_digital_port *port)<br>
+ struct intel_digital_port *intel_dig_port)<br>
{<br>
+ struct intel_encoder *intel_encoder = &intel_dig_port->base;<br>
+ enum port port;<br>
u32 bit;<br>
<br>
- switch (port->port) {<br>
+ intel_hpd_pin_to_port(intel_encoder->hpd_pin, &port);<br>
+ switch (port) {<br>
case PORT_A:<br>
bit = BXT_DE_PORT_HP_DDIA;<br>
break;<br>
@@ -4678,7 +4681,7 @@ static bool bxt_digital_port_connected(struct drm_i915_private *dev_priv,<br>
bit = BXT_DE_PORT_HP_DDIC;<br>
break;<br>
default:<br>
- MISSING_CASE(port->port);<br>
+ MISSING_CASE(port);<br>
return false;<br>
}<br>
<br>
--<br>
1.7.10.4<br>
<br>
_______________________________________________<br>
Intel-gfx mailing list<br>
<a href="mailto:Intel-gfx@lists.freedesktop.org" target="_blank">Intel-gfx@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" rel="noreferrer" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><br>
</blockquote></div></div>