<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks Rodrigo.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">This is always true. The hpd_pin is the right pin which we set for particular port. So no fallback needed.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Regards,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Sonika<o:p></o:p></span></p> <p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Rodrigo Vivi [mailto:rodrigo.vivi@gmail.com] <br> <b>Sent:</b> Friday, September 11, 2015 11:31 PM<br> <b>To:</b> Jindal, Sonika; intel-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [Intel-gfx] [PATCH] drm/i915/bxt: Use intel_encoder->hpd_pin to check live status<o:p></o:p></span></p> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal"><o:p> </o:p></p> <div> <div> <p class="MsoNormal">On Fri, Sep 11, 2015 at 4:40 AM Sonika Jindal <<a href="mailto:sonika.jindal@intel.com">sonika.jindal@intel.com</a>> wrote:<o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <p class="MsoNormal">Using intel_encoder's hpd_pin to check the live status<br> because of BXT A0/A1 WA for HPD pins and hpd_pin contains the<br> updated pin for the corresponding port.<o:p></o:p></p> </blockquote> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">It makes sense, but is it always true? or we should have a fallback to intel_dig_port->port in some case or in some stepping after A0/A1?<o:p></o:p></p> </div> <div> <p class="MsoNormal"><o:p> </o:p></p> </div> <div> <p class="MsoNormal">With this clarified feel free to use:<o:p></o:p></p> </div> <div> <p class="MsoNormal">Reviewed-by: Rodrigo Vivi <<a href="mailto:rodrigo.vivi@intel.com">rodrigo.vivi@intel.com</a>><o:p></o:p></p> </div> <div> <p class="MsoNormal"> <o:p></o:p></p> </div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <p class="MsoNormal"><br> Signed-off-by: Sonika Jindal <<a href="mailto:sonika.jindal@intel.com" target="_blank">sonika.jindal@intel.com</a>><br> ---<br> drivers/gpu/drm/i915/intel_dp.c | 9 ++++++---<br> 1 file changed, 6 insertions(+), 3 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c<br> index 796f930..bf17030 100644<br> --- a/drivers/gpu/drm/i915/intel_dp.c<br> +++ b/drivers/gpu/drm/i915/intel_dp.c<br> @@ -4663,11 +4663,14 @@ static bool vlv_digital_port_connected(struct drm_i915_private *dev_priv,<br> }<br> <br> static bool bxt_digital_port_connected(struct drm_i915_private *dev_priv,<br> - struct intel_digital_port *port)<br> + struct intel_digital_port *intel_dig_port)<br> {<br> + struct intel_encoder *intel_encoder = &intel_dig_port->base;<br> + enum port port;<br> u32 bit;<br> <br> - switch (port->port) {<br> + intel_hpd_pin_to_port(intel_encoder->hpd_pin, &port);<br> + switch (port) {<br> case PORT_A:<br> bit = BXT_DE_PORT_HP_DDIA;<br> break;<br> @@ -4678,7 +4681,7 @@ static bool bxt_digital_port_connected(struct drm_i915_private *dev_priv,<br> bit = BXT_DE_PORT_HP_DDIC;<br> break;<br> default:<br> - MISSING_CASE(port->port);<br> + MISSING_CASE(port);<br> return false;<br> }<br> <br> --<br> 1.7.10.4<br> <br> _______________________________________________<br> Intel-gfx mailing list<br> <a href="mailto:Intel-gfx@lists.freedesktop.org" target="_blank">Intel-gfx@lists.freedesktop.org</a><br> <a href="http://lists.freedesktop.org/mailman/listinfo/intel-gfx" target="_blank">http://lists.freedesktop.org/mailman/listinfo/intel-gfx</a><o:p></o:p></p> </blockquote> </div> </div> </div> </body> </html>