<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 4, 2016 at 1:17 PM, Robert Bragg <span dir="ltr"><<a href="mailto:robert@sixbynine.org" target="_blank">robert@sixbynine.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><span class="">On Thu, Feb 4, 2016 at 1:42 AM, Emil Velikov <span dir="ltr"><<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 3 February 2016 at 18:39, Robert Bragg <<a href="mailto:robert@sixbynine.org" target="_blank">robert@sixbynine.org</a>> wrote:</span><br><span class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span><br>
> +};<br>
> +<br>
> +struct drm_i915_perf_open_param {<br>
> + /** CLOEXEC, NONBLOCK... */</span><br>
> + __u32 flags;<br>
> +<br>
And ... we broke 32 bit userspare on 64 bit kernels. Please check for<br>
holes and other issues as described in Daniel Vetter's<br>
article/documentation [1]<br>
<br>
[1] <a href="https://www.kernel.org/doc/Documentation/ioctl/botching-up-ioctls.txt" rel="noreferrer" target="_blank">https://www.kernel.org/doc/Documentation/ioctl/botching-up-ioctls.txt</a></blockquote><div><br></div></span>Ah yeah, don't think this would break 32bit userspace, but still would be good to remove that hole, this has been through a few iterations and there used to be a __u32 type here, well spotted thanks.<br><br>I think I'll bump the flags to be 64bit.<br><span class=""><div> </div></span></blockquote></span></div></div></div></blockquote><div><br></div><div>Actually, just noticed that since the structure has a u32 hole at the end too I can move the trailing u32 num_properties up into here instead.<br><br></div><div>Am also renaming properties to properties_ptr which seems the norm in i915_drm.h.<br></div><br></div><div class="gmail_quote">- Robert<br></div></div></div>