Hi Poornima,<div><br></div><div>I'm not convinced with firefox.py. I see the following issues:</div><div><br></div><div>* its not generic</div><div>* It doesn't handle any exception, say if you have test script 1 to 10, if the test fails for some reason and throws any exception in test 2, tests starting 3 to 10 won't be executed</div>
<div>* The test doesn't put back to the old state, I mean if some exception happens, all the current window should be closed and should be smooth for the next test</div><div><br></div><div>Other comments from IRC:</div>
<div><br></div><div>* Create a readme file with version of Firefox, Linux distribution</div><div>* Add respective license / author files</div><div>* Move 'frm*MozillaFirefox' and other object names to some common file, so changing things will be at one place, will be really helpful at later point, if you are planing for i18n / l10n. Just change that file content with appropriate locale text and your scripts are ready for localization testing</div>
<div>* time module imported couple of times in navigation.py</div><div>* Comment navigation.py line#57, verifyabout.py line#46, verifynewtab.py line#40</div><div>* Use wait instead of time.sleep</div><div>* Additional space between url and = in verifynewtab.py</div>
<div><br></div><div>Additional comments:</div><div><br></div><div>* Don't use space between the function name and open bracket, ex: instead of 'log (' use 'log('</div><div>* Maybe you can use 'if not waittillguinotexist('window')' instead of 'if waittillguinotexist('window') == 0'</div>
<div>* At end of the complete test execution, application should exit</div><div><br></div><div>Thanks</div><div>Nagappan<br><br><div class="gmail_quote">On Wed, Apr 11, 2012 at 12:06 PM, Poornima Nayak <span dir="ltr"><<a href="mailto:mpnayak@linux.vnet.ibm.com">mpnayak@linux.vnet.ibm.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi All<br>
<br>
Sheetal & I work in IBM Linux Technology Center, we are testing<br>
Accessibility. We are using LDTP test script written for automating<br>
Firefox testing. These scripts where written based on Firefox version in<br>
2004/2006 and LDTP supported API's in 2004/2006.<br>
So we had to do lot of modification and come out with some work arounds.<br>
<br>
Nagappan already suggested lot of changes, those will be done.<br>
I specially need comment on firefox.py which triggeres test one by one.<br>
<br>
I have uploaded scripts at<br>
<a href="https://github.com/PoornimaNayak/gnomeautomation" target="_blank">https://github.com/PoornimaNayak/gnomeautomation</a>.<br>
<br>
We are planning to modify around 23 more Firefox test scripts and<br>
publish in the above repository after we learn the expectation from LDTP<br>
maintainer and the community.<br>
<br>
Regards<br>
Poornima<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
LDTP-dev mailing list<br>
<a href="mailto:LDTP-dev@lists.freedesktop.org">LDTP-dev@lists.freedesktop.org</a><br>
<a href="http://lists.freedesktop.org/mailman/listinfo/ldtp-dev" target="_blank">http://lists.freedesktop.org/mailman/listinfo/ldtp-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>Linux Desktop (GUI Application) Testing Project - <a href="http://ldtp.freedesktop.org">http://ldtp.freedesktop.org</a><br><a href="http://nagappanal.blogspot.com">http://nagappanal.blogspot.com</a><br>
</div>