[PATCH] libmbim-glib, proxy: Filter indications based on MBIM_CID_BASIC_CONNECT_DEVICE_SERVICE_SUBSCRIBE_LIST

[Greg Suarez]

On Sun, Jun 22, 2014 at 7:34 AM, Aleksander Morgado <
aleksander at aleksander.es> wrote:

> Hey Greg,
>
> On Fri, Jun 13, 2014 at 3:51 PM, Aleksander Morgado
> <aleksander at aleksander.es> wrote:
> > On Mon, Jun 9, 2014 at 9:00 PM, Greg Suarez <gpsuarez2512 at gmail.com>
> wrote:
> >> Previously mbim-proxy tracked and filtered indications of non-standard
> >> services based on whether a client has sent a message to the device with
> >> a matching UUID. This patch removes that tracking and filtering and
> >> instead tracks and filters indications based on the client sending
> >> the MBIM_CID_BASIC_CONNECT_DEVICE_SERVICE_SUBSCRIBE_LIST command to
> >> the device.
> >>
> >> The client will receive all indications if it never sends the
> >> MBIM_CID_BASIC_CONNECT_DEVICE_SERVICE_SUBSCRIBE_LIST command.
> >> Once the client sends the
> >> MBIM_CID_BASIC_CONNECT_DEVICE_SERVICE_SUBSCRIBE_LIST command, the
> >> client will only receive indications specified in the command.
> >
> > Pushed to the greg/proxy branch for now; I'll try to review it this
> weekend.
> >
>
> Reviewed it now; and also added some more commits o the greg/proxy
> branch. Please re-create your local branch based on the new greg/proxy
> branch because I rebased it.
>

Thanks


>
> There's one key thing missing still in the behavior we're supposed to
> see w.r.t. indications. In the current code with your latest patches,
> there is no difference between standard and non-standard services. If
> I'm not mistaken, by default all indications of "standard" services
> should be treated as enabled; while all indications of non-standard
> services shouldn't.
>

Just so I understand what you're saying...
So Client-A enables indications for non-standard services and then Client-B
connects to the proxy and expects the non-standard indications disabled.
So the proxy shouldn't forward the non-standard indications to Client-B
until
Client-B enables the indications, correct?


> Is that something easy to add?
>

Yes, I think so.  I should be able to get to it this week.

Regards,

Greg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libmbim-devel/attachments/20140623/c4f63b71/attachment.html>