<html> <head> <meta content="text/html; charset=UTF-8" http-equiv="Content-Type"> </head> <body bgcolor="#FFFFFF" text="#000000"> Done in attached patch. Arnaud <div class="moz-cite-prefix">On 10/04/2014 16:07, Aleksander Morgado wrote: </div> <blockquote cite="mid:CAAP7ucLxMtwK0u9-psU34dQU2DUZN1MJ+z1oLty_Bs_=sVXLLQ@mail.gmail.com" type="cite"> <pre wrap="">On Thu, Apr 10, 2014 at 4:06 PM, Aleksander Morgado <a class="moz-txt-link-rfc2396E" href="mailto:aleksander@aleksander.es"><aleksander@aleksander.es></a> wrote: </pre> <blockquote type="cite"> <pre wrap="">On Thu, Apr 10, 2014 at 2:40 PM, Arnaud Desmier <a class="moz-txt-link-rfc2396E" href="mailto:adesmier@sequans.com"><adesmier@sequans.com></a> wrote: </pre> <blockquote type="cite"> <pre wrap="">OK, so I enabled again mbim-uuid.h within generated/Makefile.am. But instead of writing a mbim_service_custom_get_string I wrote a mbim_get_service_string. This function can retrieve service nickname for any service and is called instead of mbim_service_get_string that is automatically generated. I know the difference between mbim_service_get_string and mbim_get_service_string is really tiny and can confuse but I have no better name. </pre> </blockquote> <pre wrap=""> Well... that's pretty confusing actually. How about mbim_service_lookup_name()? The method actually looks for the service name; either directly via the enum's get_string() for the standard ones or looking for a match in the registered ones. Also, the method shouldn't received a MbimService; it should get a guint, as the registered services are not included in the MbimService enum (e.g. you cannot get a registered service value as a GEnum).</pre> </blockquote> </blockquote> Oups... copy/paste issue :( <blockquote cite="mid:CAAP7ucLxMtwK0u9-psU34dQU2DUZN1MJ+z1oLty_Bs_=sVXLLQ@mail.gmail.com" type="cite"> <blockquote type="cite"> <pre wrap=""> </pre> </blockquote> <pre wrap=""> Oh, one last thing, new methods need to be added in docs/reference/libmbim-glib (i.e. compile using --enable-gtk-doc and fix warnings) </pre> </blockquote> -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.</body> </html>