[Libreoffice-bugs] [Bug 32293] LibreOffice opens and reads the basis-link file ridiculously often

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32293

--- Comment #3 from Tor Lillqvist <tlillqvist at novell.com> 2010-12-10 12:00:11 PST ---
Created an attachment (id=40993)
 View: https://bugs.freedesktop.org/attachment.cgi?id=40993
 Review: https://bugs.freedesktop.org/review?bug=32293&attachment=40993

Experimental patch

This seems to help, basis-link is opened only once.

But that doesn't really have any immediately visible speedup effect, as I had
hoped a bit. (I.e. it doesn't help bug #31716 )

The patch does a couple of things:

- remove the silliness in rtl_bootstrap_args_close() where in a debugging build
no cache was kept after all... I wasted half a day wondering why the data for
.ini files stored in the bootstrap_map hash table wasn't found after all the
next time a lookup from that same .ini file was needed, but the file had to be
loaded anew. Turns out this was intentional when bootstrap.cxx was compiled
with OSL_DEBUG_LEVEL > 1. I don't understand the usefulness of this, so kill
it.

- double the number of cached .ini files to 16.

- add a second hash table called link_map where the result of reading files
referenced to by .link syntax in .ini files is kept. I.e., in practice the
basis-link file. This indeed helps, the basis-link file is now read only once.
But as I said, that didn't have any obvious speedup effect.

- drop superfluous newlines from OSL_TRACE output. OSL_TRACE by itself appends
a newline.

But, I don't know if it is worth it to apply this patch. I would prefer to just
get rid of the basis-link and ure-link thingie completely in LibreOffice.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.