[Libreoffice-bugs] [Bug 48256] New: EasyHack: clean out Hide/Show Cursor ...

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Apr 3 18:38:02 CEST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=48256

             Bug #: 48256
           Summary: EasyHack: clean out Hide/Show Cursor ...
    Classification: Unclassified
           Product: LibreOffice
           Version: LibO Master
          Platform: Other
        OS/Version: All
            Status: UNCONFIRMED
          Severity: normal
          Priority: medium
         Component: Spreadsheet
        AssignedTo: libreoffice-bugs at lists.freedesktop.org
        ReportedBy: michael.meeks at novell.com


In the bad old days of calc, everything was rendered explicitly to the screen,
and then the cursor was rendered over the top using XOR rendering. To get this
right, before we rendered new things we would need to call:

HideCursor();
// do the incremental render
ShowCursor();

These days, we should never do that - all rendering should be done in response
to an idle handler, and should paint from scratch instead of trying to be
'clever' like this (it will increasingly not work & just waste resources on 
modern systems).

So - we need to audit the code for these Hide/Show pairs. Clearly some
instances of hiding the cursor are prolly still applicable, but we should check
all of them in sc/ 'git grep -5 HideCursor' - and remove and re-test all
instances.

Potentially we want to add some calls to Invalidate() on the cursor region when
this causes problems :-)

Thanks !

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the Libreoffice-bugs mailing list