[Libreoffice-bugs] [Bug 45020] [EDITING] selecting cells with Shift-Arrow with filtered rows/columns does not skip hidden rows/columns

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=45020

--- Comment #5 from Kohei Yoshida <kohei.yoshida at gmail.com> 2012-04-03 19:08:52 PDT ---
It's a bug.  Hidden cells should always be treated as if they don't exist when
expanding selection.

Having said that, this cursor navigation code has become such a complex monster
we need to refactor it so that we can guard it with a decent amount of unit
tests.  Otherwise it would be extremely hard to avoid introducing another
regression when fixing a bug (any bug) in this code.  I believe we talked about
this briefly before when we were talking about some unit test areas (with me,
you and Eike).

When expanding selection or navigating the cell cursor, we need to factor in:

1) hidden rows/columns
2) protected areas
3) merged cells
4) modifier keys (shift / ctrl / both)

So, one has to check all these possibilities when modifying the cursor
navigation code.  And from my own experience it's way too easy to introduce
regressions in this code...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.