[Libreoffice-bugs] [Bug 51324] crash in xmloff.Impress.XMLContentImporter::com::sun::star::document::XImporter

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=51324

Björn Michaelsen <bjoern.michaelsen at canonical.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|NOTOURBUG                   |

--- Comment #26 from Björn Michaelsen <bjoern.michaelsen at canonical.com> 2012-08-07 09:34:09 UTC ---
Reopening, finally found the root cause of this it seems and LibreOffice is not
really innocent. At:

http://opengrok.libreoffice.org/xref/core/sd/source/ui/toolpanel/TaskPaneFocusManager.cxx#229

we are generating an equal_range on an unsorted container, just to delete those
in the next line. As erasing elements from that container invalidates iterators
that is clearly illegal and one has to wonder how that ever worked at all.

Replacing line 229-230 with "mpLinks->erase(pWindow)" is not only simpler,
cleaner and easier to read, it might actually be legal. There are some other
abuses in that file that need a close look too.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.