[Libreoffice-bugs] [Bug 107569] Missing tango icon

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=107569

Maxim Monastirsky <momonasmon at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |momonasmon at gmail.com

--- Comment #8 from Maxim Monastirsky <momonasmon at gmail.com> ---
(In reply to Yousuf Philips (jay) from comment #6)
> > cmd/sc_insertframemenu.png
> > cmd/sc_formatimagemenu.png
> > cmd/sc_formatframemenu.png
> 
> menu submenus like these dont have icons in any theme so not sure about this

This "Failed to load image" warning is caused by the "Properties" section of
these commands in GenericCommands.xcu. They all have there the value "1", which
indicates that they should have an icon, see [1]. If these commands aren't
supposed to have any icons, then just removing this "Properties" section should
silence the warning IIRC.

> > cmd/sc_helpmenu.png
> 
> icons cant appear in the menu bar so not sure why this is in the list.

This caused by the presence of .uno:HelpMenu in the available commands list of
the customization dialog, although it's useless, as it isn't a command that can
do anything other than show the "Help" label. This is caused by the backing
SID_HELPMENU definition in [2], which have MenuConfig = TRUE.

So what we need here is:

1) Same as above wrt. the "Properties" section in GenericCommands.xcu.
2) Find any occurrence of SID_HELPMENU in the codebase and simply remove it.

[1]
https://opengrok.libreoffice.org/xref/core/officecfg/registry/schema/org/openoffice/Office/UI/Commands.xcs#59
[2] https://opengrok.libreoffice.org/xref/core/sfx2/sdi/sfx.sdi#1837

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20171003/1aa3e823/attachment-0001.html>