[Libreoffice-bugs] [Bug 118767] FIREBIRD: Access2Base: Dlookup function generates SQL error

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=118767

--- Comment #5 from Drew Jensen <drewjensen.inbox at gmail.com> ---
Opened an issue for the metadata uno service returning a null string for
productname.  https://bugs.documentfoundation.org/show_bug.cgi?id=118809 added
it to 'see also' here.

Even with that property not returning a name the code could handle it by
checking the URL property. For the URL there would be at least two, embedded
and file.

So, off the code in _DFunction could maybe change to

sProductName = MetaData.getDatabaseProductName()
If sProductName = "" Then
  If MetaData.URL = "sdbc:embedded:firebird" 
     Or Left( MetaData.URL, 13) = "sdbc:firebird"  Then

     sProductName = "Firebird"
  End If
End If                                              

Select Case UCase(sProductName)
  Case "MYSQL", "SQLITE"
    If psFunction = "" Then
      sTarget = psExpr
      sLimit = " LIMIT 1"
    Else
      sTarget = UCase(psFunction) & "(" & psExpr & ")"
    End If
    sSql = "SELECT " & sTarget & " AS " & sTempField & " FROM " & psDomain & 
sWhere & sOrderBy & sLimit

  Case "FIREBIRD"
    If psFunction = "" Then 
      sTarget = "FIRST 1 " & psExpr 
    Else 
      sTarget = UCase(psFunction) & "(" & psExpr & ")"
    End If
    sSql = "SELECT " & sTarget & " AS " & sTempField & " FROM " & psDomain &
sWhere & sOrderBy

....

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180718/2ab25e4c/attachment.html>