[Libreoffice-bugs] [Bug 120086] Wrong TAB-ing order of Gallery sidebar plane

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Fri Sep 28 06:45:35 UTC 2018


https://bugs.documentfoundation.org/show_bug.cgi?id=120086

--- Comment #3 from Jim Raykowski <raykowj at gmail.com> ---
Here are some code pointers.

GalleryControl class:
svx/inc/GalleryControl.hxx
svx/source/gallery2/GalleryControl.cxx

GalleryBrowser1 class:
svx/source/gallery2/galbrws1.hxx
svx/source/gallery2/galbrws1.cxx

GalleryBrowser2 class:
svx/inc/galbrws2.hxx
svx/source/gallery2/galbrws2.cxx

FocusManager class:
include/sfx2/sidebar/FocusManager.hxx
sfx2/source/sidebar/FocusManager.cxx

Add code to svx/source/gallery2/galbrws1.cxx:void GalleryBrowser1::GetFocus()
that checks if the New Theme button is enabled
svx/source/gallery2/galbrws1.hxx:class GalleryBrowser1 VclPtr<GalleryButton>
maNewTheme. The New Theme button is disabled in GalleryBrowser1 constructor if
a writable directory is not available. 

If the New Theme button is enabled then grab focus to it to make it the focus
from deck title bar to panel content transition. Currently the focus goes to
GalleryThemeListBox from deck title bar. 

Focus transition from deck title bar to panel content is done by the
FocusManager here: 
sfx2/source/sidebar/FocusManager.cxx
void FocusManager::MoveFocusInsideDeckTitle (
    const FocusLocation& rFocusLocation,
    const sal_Int32 nDirection)

Modify the tab order logic for GalleryControl to match the order specified in
Expected Results of the initial bug report.

Tab order logic for GalleryControl is found here:
svx/source/gallery2/GalleryControl.cxx
bool GalleryControl::GalleryKeyInput( const KeyEvent& rKEvt )

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20180928/9fd92799/attachment.html>


More information about the Libreoffice-bugs mailing list