[Libreoffice-bugs] [Bug 136294] Red wrong spelled lining needs a trigger to get activated

bugzilla-daemon at bugs.documentfoundation.org bugzilla-daemon at bugs.documentfoundation.org
Mon Aug 31 12:24:52 UTC 2020


https://bugs.documentfoundation.org/show_bug.cgi?id=136294

--- Comment #9 from Telesto <telesto at surfxs.nl> ---
Created attachment 164917
  --> https://bugs.documentfoundation.org/attachment.cgi?id=164917&action=edit
Bibisect log

Bisected to
author  Michael Stahl <mstahl at redhat.com>       2015-09-09 10:30:04 +0200
committer       Michael Stahl <mstahl at redhat.com>       2015-09-09 14:13:48
+0200
commit  4c91e94e892943ef5e031d65f6f42864233cb4cd (patch)
tree    c9f6e59cf2d776e028692ff19e58af57fea5deeb
parent  f9f3e97ca867db59f2fc2e4fdb5583ed49cab49c (diff)
tdf#92036: sw: fix idle spelling loop
There is a sort of intentional infinite loop in the idle spell checking
handler: while the user is typing a word, it should not be marked as
invalid yet, in order not to annoy them with red underlines.

So the word where the cursor is positioned always remained dirty, unless
you happen to have a grammar checker enabled, which clears the
paragraph's dirty flag from a separate thread.

To avoid the infinite loop, add another spell checking state "PENDING"
which is the same as dirty except that it should cancel the idle spell
checking.

The idle spell checking will run again when the user does the next
editing operation.  Notably this means if the user just moves the cursor
out of the wrongly spelled word, it won't be underlined yet, but that
appears a minor issue, and checking when the cursor leaves the word
appears too hard to implement.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4c91e94e892943ef5e031d65f6f42864233cb4cd

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200831/ea25b65c/attachment.htm>


More information about the Libreoffice-bugs mailing list