[Libreoffice-bugs] [Bug 119312] Remote control of impress; Crash in: sdext::presenter::PresenterSlideShowView::LateInit()

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=119312

--- Comment #14 from oo.o+libreoffice at windbuechse.samba-tng.org ---
I tried to use windbg more or less successfully and could have found the
problem.
It shows a access violation and a bucket id: NULL_POINTER_READ.
FAULTING_SOURCE_FILE: 
C:\cygwin64\home\buildslave\source\libo-core\sd\source\ui\remotecontrol\Communicator.cxx
FAULTING_SOURCE_LINE_NUMBER:  87

This is the function
sdlo!sd::Communicator::execute+0x00000000000004a1

I think the line number is wrong or the source code I found has evolved.
The problem, I think, is in this line: 
        OStringBuffer aBuffer;
            aBuffer.append( "slideshow_info\n" )
                .append( OUStringToOString(
::comphelper::DocumentInfo::getDocumentTitle(
xFrame->getController()->getModel() ), RTL_TEXTENCODING_UTF8 ) )
               .append("\n\n");

Before there are checks that xFrame is valid when it is used.
In this line there is no check and xFrame got de-referenced.

Is this correct?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20200907/148daedd/attachment.htm>