[Libreoffice-bugs] [Bug 143615] Impress: Crash when slide transition = 0sec

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=143615

Julien Nabet <serval2412 at yahoo.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nagy.tibor2 at nisz.hu,
                   |                            |thb at libreoffice.org,
                   |                            |vmiklos at collabora.com

--- Comment #5 from Julien Nabet <serval2412 at yahoo.fr> ---
Miklos/Thorsten/Tibor (I don't know if one of you know slideshow part, I just
used git history):
The pb is when choosing 0, "mnMinSimpleDuration" has value 0 but is used at
locations like:
 68                 nCurrElapsedTime / mnMinSimpleDuration );
 118             double nT( nCurrElapsedTime / mnMinSimpleDuration );
in slideshow/source/engine/activities/simplecontinuousactivitybase.cxx
See
https://opengrok.libreoffice.org/xref/core/slideshow/source/engine/activities/simplecontinuousactivitybase.cxx?r=c82efb61#68

Now, I wonder if it really makes sense to choose 0 and if we shouldn't put
minimum at 1.
I read https://www.w3.org/TR/SMIL/smil-timing.html#q3 since code references
SMIL but it's not very clear:
"dur
    Specifies the simple duration.
    The attribute value may be any of the following:

    Clock-value
        Specifies the length of the simple duration, measured in element active
time.
        Value must be greater than 0."  <--------- so can't be 0

"The min/max attributes provide the author with a way to control the lower and
upper bound of the element active duration.

min
    Specifies the minimum value of the active duration.
    The attribute value may be either of the following:

    Clock-value
        Specifies the length of the minimum value of the active duration,
measured in element active time.
        Value must be greater than or equal to 0.
    "media"
        Specifies the minimum value of the active duration as the intrinsic
media duration. This is only valid for elements that define media.

If there is any error in the argument value syntax for min, the attribute will
be ignored (as though it were not specified).

The default value for min is "0". This does not constrain the active duration
at all."
so can be 0.


What do you think?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice-bugs/attachments/20210730/8a15ba75/attachment.htm>