[Libreoffice-commits] .: 2 commits - sax/source sot/source

Caolán McNamara caolan at kemper.freedesktop.org
Wed Nov 24 12:02:28 PST 2010


 sax/source/tools/converter.cxx |    3 +--
 sot/source/sdstor/storage.cxx  |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

New commits:
commit 5f6381099e4385e5457d5884bafba570e2411c75
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Nov 24 16:51:43 2010 +0000

    cppcheck: unused variable

diff --git a/sax/source/tools/converter.cxx b/sax/source/tools/converter.cxx
index 91f37b0..75eb831 100644
--- a/sax/source/tools/converter.cxx
+++ b/sax/source/tools/converter.cxx
@@ -1179,11 +1179,10 @@ bool Converter::convertDateOrDateTime(
 
     const ::rtl::OUString string = rString.trim().toAsciiUpperCase();
     sal_Int32 nPos(0);
-    bool bNegative(false);
     if ((string.getLength() > nPos) && (sal_Unicode('-') == string[nPos]))
     {
+        //Negative Number
         ++nPos;
-        bNegative = true;
     }
 
     sal_Int32 nYear(0);
commit b2bbd77583a4810ec12f77333e3ea3a8331f6655
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Nov 24 16:34:59 2010 +0000

    cppcheck: The scope of this variable can be reduced

diff --git a/sot/source/sdstor/storage.cxx b/sot/source/sdstor/storage.cxx
index 09f8706..8e1f7b0 100644
--- a/sot/source/sdstor/storage.cxx
+++ b/sot/source/sdstor/storage.cxx
@@ -169,11 +169,10 @@ SotStorageStream::~SotStorageStream()
 *************************************************************************/
 void SotStorageStream::SyncSvStream()
 {
-    ULONG nPos = 0;
     if( pOwnStm )
     {
         pOwnStm->Flush();
-        nPos = pOwnStm->Tell();
+        ULONG nPos = pOwnStm->Tell();
         SetError( pOwnStm->GetError() );
         SvStream::SyncSvStream( nPos );
     }


More information about the Libreoffice-commits mailing list