[Libreoffice-commits] .: Branch 'libreoffice-3-4' - patches/dev300
Tor Lillqvist
tml at kemper.freedesktop.org
Fri Apr 8 01:57:16 PDT 2011
patches/dev300/apply | 3
patches/dev300/svx-i18n-ordinal-autocorr.diff | 284 --------------------------
2 files changed, 287 deletions(-)
New commits:
commit 8b8b5fa0e92ac7c067d0f2a48a0635225f5ece6a
Author: Tor Lillqvist <tlillqvist at novell.com>
Date: Fri Apr 8 11:56:18 2011 +0300
svx-i18n-ordinal-autocorr.diff has been integrated
diff --git a/patches/dev300/apply b/patches/dev300/apply
index 812b558..b97c756 100644
--- a/patches/dev300/apply
+++ b/patches/dev300/apply
@@ -1166,9 +1166,6 @@ icu-arm.diff, doko
svx-sdrobjeditview-update-edit-area.diff, n#305205, n#347355, rodo
goodies-eps-filter-unix.diff, n#200053, rodo
-# internationalized ordinal suffix autocorrection. Needs ICU 4.2
-svx-i18n-ordinal-autocorr.diff, i#20348, cbosdo
-
[ OxygenOfficeDefaultSettings ]
# Always enable extended tips
i27928-extended-tips-on.diff
diff --git a/patches/dev300/svx-i18n-ordinal-autocorr.diff b/patches/dev300/svx-i18n-ordinal-autocorr.diff
deleted file mode 100644
index 44677cd..0000000
--- a/patches/dev300/svx-i18n-ordinal-autocorr.diff
+++ /dev/null
@@ -1,284 +0,0 @@
---- editeng/source/misc/svxacorr.cxx
-+++ editeng/source/misc/svxacorr.cxx
-@@ -47,6 +47,7 @@
- #include <com/sun/star/i18n/UnicodeType.hdl>
- #include <unotools/collatorwrapper.hxx>
- #include <com/sun/star/i18n/CollatorOptions.hpp>
-+#include <com/sun/star/i18n/XOrdinalSuffix.hpp>
- #include <com/sun/star/i18n/UnicodeScript.hpp>
- #include <unotools/localedatawrapper.hxx>
- #include <unotools/transliterationwrapper.hxx>
-@@ -488,48 +489,58 @@ BOOL SvxAutoCorrect::FnChgOrdinalNumber(
- if( !lcl_IsInAsciiArr( sImplEndSkipChars, rTxt.GetChar( nEndPos - 1 ) ))
- break;
-
-- if( 2 < nEndPos - nSttPos &&
-- rCC.isDigit( rTxt, nEndPos - 3 ) )
-+
-+ // Get the last number in the string to check
-+ xub_StrLen nNumEnd = nEndPos;
-+ bool foundEnd = false;
-+ bool validNumber = true;
-+ xub_StrLen i = nEndPos;
-+
-+ do
- {
-- static sal_Char const
-- sAll[] = "th", /* rest */
-- sFirst[] = "st", /* 1 */
-- sSecond[] = "nd", /* 2 */
-- sThird[] = "rd"; /* 3 */
-- static const sal_Char* const aNumberTab[ 4 ] =
-+ i--;
-+ bool isDigit = rCC.isDigit( rTxt, i );
-+ if ( foundEnd )
-+ validNumber |= isDigit;
-+
-+ if ( isDigit && !foundEnd )
- {
-- sAll, sFirst, sSecond, sThird
-- };
--
-- sal_Unicode c = rTxt.GetChar( nEndPos - 3 );
-- if( ( c -= '0' ) > 3 )
-- c = 0;
--
-- bChg = ( ((sal_Unicode)*((aNumberTab[ c ])+0)) ==
-- rTxt.GetChar( nEndPos - 2 ) &&
-- ((sal_Unicode)*((aNumberTab[ c ])+1)) ==
-- rTxt.GetChar( nEndPos - 1 )) ||
-- ( 3 < nEndPos - nSttPos &&
-- ( ((sal_Unicode)*(sAll+0)) == rTxt.GetChar( nEndPos - 2 ) &&
-- ((sal_Unicode)*(sAll+1)) == rTxt.GetChar( nEndPos - 1 )));
--
-- if( bChg )
-+ foundEnd = true;
-+ nNumEnd = i;
-+ }
-+ }
-+ while ( i > nSttPos );
-+
-+ if ( foundEnd && validNumber ) {
-+ sal_Int32 nNum = rTxt.Copy( nSttPos, nNumEnd - nSttPos + 1 ).ToInt32( );
-+
-+ // Check if the characters after that number correspond to the ordinal suffix
-+ rtl::OUString sServiceName = rtl::OUString::createFromAscii( "com.sun.star.i18n.OrdinalSuffix" );
-+ uno::Reference< i18n::XOrdinalSuffix > xOrdSuffix(
-+ comphelper::createProcessComponent( sServiceName ),
-+ uno::UNO_QUERY );
-+
-+ if ( xOrdSuffix.is( ) )
- {
-- // then check to the start, if all are numbers
-- for( xub_StrLen n = nEndPos - 3; nSttPos < n; )
-- if( !rCC.isDigit( rTxt, --n ) )
-+ uno::Sequence< rtl::OUString > aSuffixes = xOrdSuffix->getOrdinalSuffix( nNum, rCC.getLocale( ) );
-+ for ( sal_Int32 nSuff = 0; nSuff < aSuffixes.getLength(); nSuff++ )
-+ {
-+ String sSuffix( aSuffixes[ nSuff ] );
-+ String sEnd = rTxt.Copy( nNumEnd + 1, nEndPos - nNumEnd - 1 );
-+
-+ if ( sSuffix == sEnd )
- {
-- bChg = !rCC.isLetter( rTxt, n );
-- break;
-+ // Check if the ordinal suffix has to be set as super script
-+ if ( rCC.isLetter( sSuffix ) )
-+ {
-+ // Do the change
-+ SvxEscapementItem aSvxEscapementItem( DFLT_ESC_AUTO_SUPER,
-+ DFLT_ESC_PROP, SID_ATTR_CHAR_ESCAPEMENT );
-+ rDoc.SetAttr( nNumEnd + 1 , nEndPos,
-+ SID_ATTR_CHAR_ESCAPEMENT,
-+ aSvxEscapementItem);
-+ }
- }
--
-- if( bChg ) // then set the escapement attribute
-- {
-- SvxEscapementItem aSvxEscapementItem( DFLT_ESC_AUTO_SUPER,
-- DFLT_ESC_PROP, SID_ATTR_CHAR_ESCAPEMENT );
-- rDoc.SetAttr( nEndPos - 2, nEndPos,
-- SID_ATTR_CHAR_ESCAPEMENT,
-- aSvxEscapementItem);
- }
- }
-
---- i18npool/inc/ordinalsuffix.hxx
-+++ i18npool/inc/ordinalsuffix.hxx
-@@ -44,7 +44,7 @@ class OrdinalSuffix : public cppu::WeakImplHelper2
- virtual ~OrdinalSuffix();
-
- // XOrdinalSuffix
-- virtual rtl::OUString SAL_CALL getOrdinalSuffix( sal_Int32 nNumber, const com::sun::star::lang::Locale &rLocale) throw(com::sun::star::uno::RuntimeException);
-+ virtual com::sun::star::uno::Sequence< rtl::OUString > SAL_CALL getOrdinalSuffix( sal_Int32 nNumber, const com::sun::star::lang::Locale &rLocale ) throw(com::sun::star::uno::RuntimeException);
-
- // XServiceInfo
- virtual rtl::OUString SAL_CALL getImplementationName() throw(com::sun::star::uno::RuntimeException);
---- i18npool/source/ordinalsuffix/ordinalsuffix.cxx
-+++ i18npool/source/ordinalsuffix/ordinalsuffix.cxx
-@@ -31,10 +31,14 @@
- #include <string.h>
- #include "ordinalsuffix.hxx"
-
-+#include <unicode/rbnf.h>
-+#include <unicode/normlzr.h>
-+
-+#define CSTR( ouStr ) rtl::OUStringToOString( ouStr, RTL_TEXTENCODING_UTF8 ).getStr( )
-
- using namespace ::com::sun::star::i18n;
- using namespace ::com::sun::star::uno;
--using namespace ::com::sun::star::lang;
-+using namespace ::com::sun::star;
- using namespace ::rtl;
-
- namespace com { namespace sun { namespace star { namespace i18n {
-@@ -51,50 +55,61 @@ OrdinalSuffix::~OrdinalSuffix()
- }
-
-
--static OUString getOrdinalSuffixEn( sal_Int32 nNumber )
-+/*
-+ * For this method to properly return the ordinal suffix for other locales
-+ * than english ones, ICU 4.2+ has to be used.
-+ */
-+uno::Sequence< OUString > SAL_CALL OrdinalSuffix::getOrdinalSuffix( sal_Int32 nNumber,
-+ const lang::Locale &aLocale ) throw( RuntimeException )
- {
-- OUString retValue;
--
-- switch( labs( nNumber ) % 100 )
-+ uno::Sequence< OUString > retValue;
-+
-+ // Get the value from ICU
-+ UErrorCode nCode = U_ZERO_ERROR;
-+ const icu::Locale rIcuLocale(
-+ CSTR( aLocale.Language ),
-+ CSTR( aLocale.Country ),
-+ CSTR( aLocale.Variant ) );
-+ icu::RuleBasedNumberFormat formatter(
-+ icu::URBNF_ORDINAL, rIcuLocale, nCode );
-+
-+ if ( U_SUCCESS( nCode ) )
- {
-- case 11: case 12: case 13:
-- retValue = OUString(RTL_CONSTASCII_USTRINGPARAM("th"));
-- break;
-- default:
-- switch( nNumber % 10 )
-+ int32_t nRuleSets = formatter.getNumberOfRuleSetNames( );
-+ for ( int32_t i = 0; i < nRuleSets; i++ )
-+ {
-+ icu::UnicodeString ruleSet = formatter.getRuleSetName( i );
-+ // format the string
-+ icu::UnicodeString icuRet;
-+ icu::FieldPosition icuPos;
-+ formatter.format( (int32_t)nNumber, ruleSet, icuRet, icuPos, nCode );
-+
-+ if ( U_SUCCESS( nCode ) )
- {
-- case 1:
-- retValue = OUString(RTL_CONSTASCII_USTRINGPARAM("st"));
-- break;
-- case 2:
-- retValue = OUString(RTL_CONSTASCII_USTRINGPARAM("nd"));
-- break;
-- case 3:
-- retValue = OUString(RTL_CONSTASCII_USTRINGPARAM("rd"));
-- break;
-- default:
-- retValue = OUString(RTL_CONSTASCII_USTRINGPARAM("th"));
-- break;
-+ // Apply NFKC normalization to get normal letters
-+ icu::UnicodeString normalized;
-+ nCode = U_ZERO_ERROR;
-+ icu::Normalizer::normalize( icuRet, UNORM_NFKC, 0, normalized, nCode );
-+ if ( U_SUCCESS( nCode ) && ( normalized != icuRet ) )
-+ {
-+ // Convert the normalized UnicodeString to OUString
-+ OUString sValue( reinterpret_cast<const sal_Unicode *>( normalized.getBuffer( ) ), normalized.length() );
-+
-+ // Remove the number to get the prefix
-+ sal_Int32 len = OUString::valueOf( nNumber ).getLength( );
-+
-+ sal_Int32 newLength = retValue.getLength() + 1;
-+ retValue.realloc( newLength );
-+ retValue[ newLength - 1 ] = sValue.copy( len );
-+ }
- }
-- break;
-+ }
- }
-
- return retValue;
- }
-
-
--OUString SAL_CALL OrdinalSuffix::getOrdinalSuffix( sal_Int32 nNumber,
-- const Locale &aLocale ) throw( RuntimeException )
--{
-- OUString retValue;
--
-- if (aLocale.Language.equalsAsciiL("en",2))
-- retValue = getOrdinalSuffixEn( nNumber );
--
-- return retValue;
--}
--
--
- const sal_Char cOrdinalSuffix[] = "com.sun.star.i18n.OrdinalSuffix";
-
- OUString SAL_CALL OrdinalSuffix::getImplementationName(void) throw( RuntimeException )
---- offapi/com/sun/star/i18n/XOrdinalSuffix.idl
-+++ offapi/com/sun/star/i18n/XOrdinalSuffix.idl
-@@ -45,22 +45,24 @@ module com { module sun { module star { module i18n {
- ATTENTION: This interface is marked <em>internal</em> and does not
- have the <em>published</em> flag, which means it is subject to
- change without notice and should not be used outside the OOo core.
-- The current version is a draft and works only for English language
-- locales. Future enhancements adding functionality for other locales
-- should use the "ordinal" RuleBasedNumberFormat of the ICU if
-- possible, see
-- http://icu.sourceforge.net/apiref/icu4c/classRuleBasedNumberFormat.html
-- which might make it necessary to change the interface.
- */
-
- interface XOrdinalSuffix : com::sun::star::uno::XInterface
- {
- //------------------------------------------------------------------------
-- /** Returns the ordinal suffix for the number, for example,
-- "<b>st</b>", "<b>nd</b>", "<b>rd</b>", "<b>th</b>"
-- in an English locale.
-+ /** Returns all the possible ordinal suffixes for the number.
-+
-+ This method will provide "<b>st</b>", "<b>nd</b>", "<b>rd</b>",
-+ "<b>th</b>" for an English locale, depending on the provided number.
-+ In some locales like French, Italian or Spanish it ca return several
-+ suffixes for one number.
-+
-+ Examples: for the number '1', the values will be <b>st</b> in
-+ English, but <b>er</b> and <b>re</b> in French. All these values
-+ may depend on the underlying version of ICU.
-+
- */
-- string getOrdinalSuffix( [in] long nNumber, [in] com::sun::star::lang::Locale aLocale );
-+ sequence< string > getOrdinalSuffix( [in] long nNumber, [in] com::sun::star::lang::Locale aLocale );
- };
-
- //============================================================================
---- sc/source/core/data/globalx.cxx
-+++ sc/source/core/data/globalx.cxx
-@@ -159,8 +159,12 @@ String ScGlobal::GetOrdinalSuffix( sal_Int32 nNumber)
- {
- try
- {
-- return xOrdinalSuffix->getOrdinalSuffix( nNumber,
-+ uno::Sequence< rtl::OUString > aSuffixes = xOrdinalSuffix->getOrdinalSuffix( nNumber,
- ScGlobal::pLocaleData->getLocale());
-+ if ( aSuffixes.getLength() > 0 )
-+ return aSuffixes[0];
-+ else
-+ return String();
- }
- catch ( Exception& )
- {
More information about the Libreoffice-commits
mailing list