[Libreoffice-commits] .: 2 commits - sc/source
Caolán McNamara
caolan at kemper.freedesktop.org
Thu Apr 14 06:50:43 PDT 2011
sc/source/ui/unoobj/chart2uno.cxx | 2 -
sc/source/ui/unoobj/listenercalls.cxx | 2 -
sc/source/ui/vba/vbaformat.cxx | 50 +++++++++++++++++-----------------
3 files changed, 27 insertions(+), 27 deletions(-)
New commits:
commit cf18623c9356846401e5240869e9b292f09b1870
Author: Caolán McNamara <caolanm at redhat.com>
Date: Thu Apr 14 14:44:04 2011 +0100
catch by const reference
diff --git a/sc/source/ui/unoobj/listenercalls.cxx b/sc/source/ui/unoobj/listenercalls.cxx
index 281997d..18f8313 100644
--- a/sc/source/ui/unoobj/listenercalls.cxx
+++ b/sc/source/ui/unoobj/listenercalls.cxx
@@ -73,7 +73,7 @@ void ScUnoListenerCalls::ExecuteAndClear()
{
aEntry.xListener->modified( aEntry.aEvent );
}
- catch ( uno::RuntimeException )
+ catch ( const uno::RuntimeException& )
{
// the listener is an external object and may throw a RuntimeException
// for reasons we don't know
diff --git a/sc/source/ui/vba/vbaformat.cxx b/sc/source/ui/vba/vbaformat.cxx
index 3681c67..cc625c8 100644
--- a/sc/source/ui/vba/vbaformat.cxx
+++ b/sc/source/ui/vba/vbaformat.cxx
@@ -68,7 +68,7 @@ ScVbaFormat< Ifc1 >::ScVbaFormat( const uno::Reference< XHelperInterface >& xPar
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( "XModel Interface could not be retrieved") ) );
mxNumberFormatsSupplier.set( mxModel, uno::UNO_QUERY_THROW );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -106,7 +106,7 @@ ScVbaFormat<Ifc1>::setVerticalAlignment( const uno::Any& _oAlignment) throw (s
}
mxPropertySet->setPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNONAME_CELLVJUS ) ), aVal );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -142,7 +142,7 @@ ScVbaFormat<Ifc1>::getVerticalAlignment( ) throw (script::BasicErrorException,
}
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -182,7 +182,7 @@ ScVbaFormat<Ifc1>::setHorizontalAlignment( const uno::Any& HorizontalAlignment )
if ( aVal.hasValue() )
mxPropertySet->setPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNONAME_CELLHJUS ) ), aVal );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -223,7 +223,7 @@ ScVbaFormat<Ifc1>::getHorizontalAlignment( ) throw (script::BasicErrorException
}
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -262,7 +262,7 @@ ScVbaFormat<Ifc1>::setOrientation( const uno::Any& _aOrientation ) throw (script
mxPropertySet->setPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNONAME_CELLORI ) ), aVal );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -299,7 +299,7 @@ ScVbaFormat<Ifc1>::getOrientation( ) throw (script::BasicErrorException, uno::R
}
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -314,7 +314,7 @@ ScVbaFormat<Ifc1>::setWrapText( const uno::Any& _aWrapText ) throw (script::Basi
{
mxPropertySet->setPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNONAME_WRAP ) ), _aWrapText);
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -333,7 +333,7 @@ ScVbaFormat<Ifc1>::getWrapText( ) throw (script::BasicErrorException, uno::Runt
aWrap = mxPropertySet->getPropertyValue(aPropName);
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -392,7 +392,7 @@ ScVbaFormat<Ifc1>::getNumberFormatLocal( ) throw (script::BasicErrorException,
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -414,7 +414,7 @@ ScVbaFormat<Ifc1>::setNumberFormat( lang::Locale _aLocale, const rtl::OUString&
}
mxPropertySet->setPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNO_NUMBERFO ) ), uno::makeAny( nFormat ) );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -443,7 +443,7 @@ ScVbaFormat<Ifc1>::setNumberFormatLocal( const uno::Any& _oLocalFormatString ) t
nNewFormat = xNumberFormats->addNew(sLocalFormatString, aRangeLocale);
mxPropertySet->setPropertyValue(sNumFormat, uno::makeAny( nNewFormat ));
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -473,7 +473,7 @@ ScVbaFormat<Ifc1>::setNumberFormat( const uno::Any& _oFormatString ) throw (scri
sal_Int32 nNewFormat = xNumberFormatTypes->getFormatForLocale(nFormat, aRangeLocale);
mxPropertySet->setPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNO_NUMBERFO ) ), uno::makeAny( nNewFormat));
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -498,7 +498,7 @@ ScVbaFormat<Ifc1>::setIndentLevel( const uno::Any& _aLevel ) throw (script::Basi
mxPropertySet->setPropertyValue( sHoriJust, uno::makeAny( table::CellHoriJustify_LEFT) ) ;
mxPropertySet->setPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNONAME_PINDENT ) ), uno::makeAny( sal_Int16(nLevel * 352.8) ) );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -521,7 +521,7 @@ ScVbaFormat<Ifc1>::getIndentLevel( ) throw (script::BasicErrorException, uno::R
NRetIndentLevel = uno::makeAny( sal_Int32(0) );
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -543,7 +543,7 @@ ScVbaFormat<Ifc1>::setLocked( const uno::Any& _aLocked ) throw (script::BasicErr
aCellProtection.IsLocked = bIsLocked;
mxPropertySet->setPropertyValue(sCellProt, uno::makeAny( aCellProtection ) );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -563,7 +563,7 @@ ScVbaFormat<Ifc1>::setFormulaHidden( const uno::Any& FormulaHidden ) throw (scri
aCellProtection.IsFormulaHidden = bIsFormulaHidden;
mxPropertySet->setPropertyValue(sCellProt,uno::makeAny(aCellProtection));
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception( SbERR_METHOD_FAILED, rtl::OUString() );
}
@@ -596,7 +596,7 @@ ScVbaFormat<Ifc1>::getLocked( ) throw (script::BasicErrorException, uno::Runtim
}
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -629,7 +629,7 @@ ScVbaFormat<Ifc1>::getFormulaHidden( ) throw (script::BasicErrorException, uno:
}
}
}
- catch (uno::Exception e)
+ catch (const uno::Exception&)
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -644,7 +644,7 @@ ScVbaFormat<Ifc1>::setShrinkToFit( const uno::Any& ShrinkToFit ) throw (script::
{
mxPropertySet->setPropertyValue(rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNONAME_SHRINK_TO_FIT ) ), ShrinkToFit);
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_NOT_IMPLEMENTED, rtl::OUString() );
}
@@ -662,7 +662,7 @@ ScVbaFormat<Ifc1>::getShrinkToFit( ) throw (script::BasicErrorException, uno::R
if (!isAmbiguous(sShrinkToFit))
aRet = mxPropertySet->getPropertyValue(sShrinkToFit);
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_NOT_IMPLEMENTED, rtl::OUString());
}
@@ -695,7 +695,7 @@ ScVbaFormat<Ifc1>::setReadingOrder( const uno::Any& ReadingOrder ) throw (script
}
mxPropertySet->setPropertyValue( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( SC_UNONAME_WRITING ) ), aVal );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -726,7 +726,7 @@ ScVbaFormat<Ifc1>::getReadingOrder( ) throw (script::BasicErrorException, uno::
}
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_NOT_IMPLEMENTED, rtl::OUString());
}
@@ -754,7 +754,7 @@ ScVbaFormat< Ifc1 >::getNumberFormat( ) throw (script::BasicErrorException, uno
aFormat = uno::makeAny( sFormat );
}
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
@@ -771,7 +771,7 @@ ScVbaFormat<Ifc1>::isAmbiguous(const rtl::OUString& _sPropertyName) throw ( scri
if (mbCheckAmbiguoity)
bResult = ( getXPropertyState()->getPropertyState(_sPropertyName) == beans::PropertyState_AMBIGUOUS_VALUE );
}
- catch (uno::Exception& )
+ catch (const uno::Exception& )
{
DebugHelper::exception(SbERR_METHOD_FAILED, rtl::OUString());
}
commit 08214ff5a567bb1517d3ef44b2182c4e5fc3d2fc
Author: Caolán McNamara <caolanm at redhat.com>
Date: Wed Apr 13 21:44:23 2011 +0100
createFromAscii->RTL_CONSTASCII_USTRINGPARAM
diff --git a/sc/source/ui/unoobj/chart2uno.cxx b/sc/source/ui/unoobj/chart2uno.cxx
index 32fc54a..7d91484 100644
--- a/sc/source/ui/unoobj/chart2uno.cxx
+++ b/sc/source/ui/unoobj/chart2uno.cxx
@@ -1065,7 +1065,7 @@ Reference< chart2::data::XLabeledDataSequence > lcl_createLabeledDataSequenceFro
if ( xContext.is() )
{
xResult.set( xContext->getServiceManager()->createInstanceWithContext(
- ::rtl::OUString::createFromAscii( "com.sun.star.chart2.data.LabeledDataSequence" ),
+ ::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("com.sun.star.chart2.data.LabeledDataSequence")),
xContext ), uno::UNO_QUERY_THROW );
}
if ( bHasValues )
More information about the Libreoffice-commits
mailing list