[Libreoffice-commits] .: Branch 'libreoffice-3-3' - vcl/source

Tor Lillqvist tml at kemper.freedesktop.org
Fri Jan 21 03:47:36 PST 2011


 vcl/source/window/toolbox2.cxx |    7 -------
 1 file changed, 7 deletions(-)

New commits:
commit 6daaf110b9d13220763bb0fe6041fd38c95ba797
Author: Tor Lillqvist <tlillqvist at novell.com>
Date:   Fri Jan 21 13:31:46 2011 +0200

    Avoid a pointless GetHelpText() call in the toolbox, too
    
    Fixes fdo#33315. GetHelpText() can be quite heavy, see fdo#33088. Also
    here the return value is passed to ShowHelpStatusText() which doesn't
    do anything at all.
    
    Signed-off-by: Caolan McNamara <caolanm at redhat.com>

diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx
index d101122..29ef64c 100644
--- a/vcl/source/window/toolbox2.cxx
+++ b/vcl/source/window/toolbox2.cxx
@@ -521,13 +521,6 @@ void ToolBox::Highlight()
 {
     ImplCallEventListeners( VCLEVENT_TOOLBOX_HIGHLIGHT );
     maHighlightHdl.Call( this );
-
-    XubString aStr = GetHelpText( mnCurItemId );
-    if ( aStr.Len() || mbHideStatusText )
-    {
-        GetpApp()->ShowHelpStatusText( aStr );
-        mbHideStatusText = TRUE;
-    }
 }
 
 // -----------------------------------------------------------------------


More information about the Libreoffice-commits mailing list