[Libreoffice-commits] .: 3 commits - connectivity/source

Tor Lillqvist tml at kemper.freedesktop.org
Mon Jan 24 14:59:13 PST 2011


 connectivity/source/drivers/ado/AResultSet.cxx      |    2 +-
 connectivity/source/drivers/ado/AStatement.cxx      |    6 +++---
 connectivity/source/drivers/ado/Awrapado.cxx        |   14 +++++++-------
 connectivity/source/drivers/dbase/DTable.cxx        |    2 +-
 connectivity/source/drivers/mozab/makefile_mozab.mk |    3 +--
 connectivity/source/inc/ado/AResultSet.hxx          |    2 +-
 connectivity/source/inc/ado/AStatement.hxx          |    2 +-
 connectivity/source/inc/ado/Awrapado.hxx            |    8 ++++----
 8 files changed, 19 insertions(+), 20 deletions(-)

New commits:
commit e9737f2b0214336176f79485cc4318e2a6ddc232
Author: Tor Lillqvist <tlillqvist at novell.com>
Date:   Tue Jan 25 00:57:51 2011 +0200

    Use correct parameter types in ADO API calls
    
    Fixes compilation errors on 64-bit Windows.

diff --git a/connectivity/source/drivers/ado/AResultSet.cxx b/connectivity/source/drivers/ado/AResultSet.cxx
index 3d6259a..366ac23 100644
--- a/connectivity/source/drivers/ado/AResultSet.cxx
+++ b/connectivity/source/drivers/ado/AResultSet.cxx
@@ -279,7 +279,7 @@ sal_Int32 SAL_CALL OResultSet::getRow(  ) throw(SQLException, RuntimeException)
     checkDisposed(OResultSet_BASE::rBHelper.bDisposed);
 
 
-    PositionEnum aPos;
+    PositionEnum_Param aPos;
     m_pRecordSet->get_AbsolutePosition(&aPos);
     return  (aPos > 0) ? aPos : m_nRowPos;
     // return the rowcount from driver if the driver doesn't support this return our count
diff --git a/connectivity/source/drivers/ado/AStatement.cxx b/connectivity/source/drivers/ado/AStatement.cxx
index fbb00b9..2708607 100644
--- a/connectivity/source/drivers/ado/AStatement.cxx
+++ b/connectivity/source/drivers/ado/AStatement.cxx
@@ -390,7 +390,7 @@ Sequence< sal_Int32 > SAL_CALL OStatement::executeBatch(  ) throw(SQLException,
         {
             assignRecordSet( pSet );
 
-            sal_Int32 nValue;
+            ADO_LONGPTR nValue;
             if(m_RecordSet.get_RecordCount(nValue))
                 pArray[j] = nValue;
         }
@@ -443,7 +443,7 @@ sal_Int32 SAL_CALL OStatement_Base::getUpdateCount(  ) throw(SQLException, Runti
     checkDisposed(OStatement_BASE::rBHelper.bDisposed);
 
 
-    sal_Int32 nRet;
+    ADO_LONGPTR nRet;
     if(m_RecordSet.IsValid() && m_RecordSet.get_RecordCount(nRet))
         return nRet;
     return -1;
@@ -512,7 +512,7 @@ sal_Int32 OStatement_Base::getQueryTimeOut() const  throw(SQLException, RuntimeE
 //------------------------------------------------------------------------------
 sal_Int32 OStatement_Base::getMaxRows() const throw(SQLException, RuntimeException)
 {
-    sal_Int32 nRet=-1;
+    ADO_LONGPTR nRet=-1;
     if(!(m_RecordSet.IsValid() && m_RecordSet.get_MaxRecords(nRet)))
         ::dbtools::throwFunctionSequenceException(NULL);
     return nRet;
diff --git a/connectivity/source/drivers/ado/Awrapado.cxx b/connectivity/source/drivers/ado/Awrapado.cxx
index bcd696a..aec997e 100644
--- a/connectivity/source/drivers/ado/Awrapado.cxx
+++ b/connectivity/source/drivers/ado/Awrapado.cxx
@@ -485,7 +485,7 @@ WpADOProperties WpADOField::get_Properties()
  sal_Int32 WpADOField::GetActualSize() const
 {
      OSL_ENSURE(pInterface,"Interface is null!");
-    sal_Int32 nActualSize=0;
+    ADO_LONGPTR nActualSize=0;
     pInterface->get_ActualSize(&nActualSize);
     return nActualSize;
 }
@@ -509,7 +509,7 @@ sal_Int32 WpADOField::GetStatus() const
 sal_Int32 WpADOField::GetDefinedSize() const
 {
     OSL_ENSURE(pInterface,"Interface is null!");
-    sal_Int32 nDefinedSize=0;
+    ADO_LONGPTR nDefinedSize=0;
     pInterface->get_DefinedSize(&nDefinedSize);
     return nDefinedSize;
 }
@@ -776,10 +776,10 @@ void WpADORecordset::Close()
     return bSupports == VARIANT_TRUE;
 }
 
-PositionEnum WpADORecordset::get_AbsolutePosition()
+PositionEnum_Param WpADORecordset::get_AbsolutePosition()
 {
     OSL_ENSURE(pInterface,"Interface is null!");
-    PositionEnum aTemp=adPosUnknown;
+    PositionEnum_Param aTemp=adPosUnknown;
     pInterface->get_AbsolutePosition(&aTemp);
     return aTemp;
 }
@@ -898,19 +898,19 @@ WpADOProperties WpADORecordset::get_Properties() const
     return SUCCEEDED(pInterface->NextRecordset(&RecordsAffected,ppiRset));
 }
 
- sal_Bool WpADORecordset::get_RecordCount(sal_Int32 &_nRet) const
+ sal_Bool WpADORecordset::get_RecordCount(ADO_LONGPTR &_nRet) const
 {
      OSL_ENSURE(pInterface,"Interface is null!");
     return SUCCEEDED(pInterface->get_RecordCount(&_nRet));
 }
 
- sal_Bool WpADORecordset::get_MaxRecords(sal_Int32 &_nRet) const
+ sal_Bool WpADORecordset::get_MaxRecords(ADO_LONGPTR &_nRet) const
 {
      OSL_ENSURE(pInterface,"Interface is null!");
     return SUCCEEDED(pInterface->get_MaxRecords(&_nRet));
 }
 
- sal_Bool WpADORecordset::put_MaxRecords(sal_Int32 _nRet)
+ sal_Bool WpADORecordset::put_MaxRecords(ADO_LONGPTR _nRet)
 {
      OSL_ENSURE(pInterface,"Interface is null!");
     return SUCCEEDED(pInterface->put_MaxRecords(_nRet));
diff --git a/connectivity/source/inc/ado/AResultSet.hxx b/connectivity/source/inc/ado/AResultSet.hxx
index 2136c0b..b71730a 100644
--- a/connectivity/source/inc/ado/AResultSet.hxx
+++ b/connectivity/source/inc/ado/AResultSet.hxx
@@ -79,7 +79,7 @@ namespace connectivity
             ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XResultSetMetaData>        m_xMetaData;
             ::std::vector<OLEVariant>		m_aBookmarks;
             OLEVariant						m_aValue;
-            sal_Int32						m_nRowPos;
+            ADO_LONGPTR						m_nRowPos;
             sal_Bool						m_bWasNull;
             sal_Bool						m_bEOF;
             sal_Bool						m_bOnFirstAfterOpen;
diff --git a/connectivity/source/inc/ado/AStatement.hxx b/connectivity/source/inc/ado/AStatement.hxx
index 841bcfd..91f873b 100644
--- a/connectivity/source/inc/ado/AStatement.hxx
+++ b/connectivity/source/inc/ado/AStatement.hxx
@@ -86,7 +86,7 @@ namespace connectivity
             ::std::vector<connectivity::OTypeInfo>		m_aTypeInfo;	// Hashtable containing an entry
                                                                         //  for each row returned by
                                                                         //  DatabaseMetaData.getTypeInfo.
-            sal_Int32									m_nMaxRows;
+            ADO_LONGPTR									m_nMaxRows;
             sal_Int32									m_nFetchSize;
             LockTypeEnum								m_eLockType;
             CursorTypeEnum								m_eCursorType;
diff --git a/connectivity/source/inc/ado/Awrapado.hxx b/connectivity/source/inc/ado/Awrapado.hxx
index 8c69f6e..cc8d7ca 100644
--- a/connectivity/source/inc/ado/Awrapado.hxx
+++ b/connectivity/source/inc/ado/Awrapado.hxx
@@ -336,7 +336,7 @@ namespace connectivity
              sal_Bool Cancel() const;
              sal_Int32 get_State( );
              sal_Bool Supports( /* [in] */ CursorOptionEnum CursorOptions);
-            PositionEnum get_AbsolutePosition();
+            PositionEnum_Param get_AbsolutePosition();
              void GetDataSource(IUnknown** pIUnknown) const ;
              void PutRefDataSource(IUnknown* pIUnknown);
              void GetBookmark(VARIANT& var);
@@ -358,9 +358,9 @@ namespace connectivity
              sal_Bool CancelUpdate();
              WpADOProperties get_Properties() const;
              sal_Bool NextRecordset(OLEVariant& RecordsAffected,ADORecordset** ppiRset);
-             sal_Bool get_RecordCount(sal_Int32 &_nRet) const;
-             sal_Bool get_MaxRecords(sal_Int32 &_nRet) const;
-             sal_Bool put_MaxRecords(sal_Int32 _nRet);
+             sal_Bool get_RecordCount(ADO_LONGPTR &_nRet) const;
+             sal_Bool get_MaxRecords(ADO_LONGPTR &_nRet) const;
+             sal_Bool put_MaxRecords(ADO_LONGPTR _nRet);
              sal_Bool get_CursorType(CursorTypeEnum &_nRet) const;
              sal_Bool put_CursorType(CursorTypeEnum _nRet);
              sal_Bool get_LockType(LockTypeEnum &_nRet) const;
commit 687d3b8e68e59946d12e996f1aa7d28cfb2d414d
Author: Tor Lillqvist <tlillqvist at novell.com>
Date:   Tue Jan 25 00:47:45 2011 +0200

    Both argumensts to Min must be of same type

diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DTable.cxx
index fd941e0..a4322ee 100644
--- a/connectivity/source/drivers/dbase/DTable.cxx
+++ b/connectivity/source/drivers/dbase/DTable.cxx
@@ -1313,7 +1313,7 @@ BOOL ODbaseTable::CreateFile(const INetURLObject& aFile, BOOL& bCreateMemo)
                     {
                         throwInvalidColumnType(STR_INVALID_COLUMN_PRECISION, aName);
                     }
-                    (*m_pFileStream) << (BYTE) Min((ULONG)nPrecision, 255UL);      //Feldlaenge
+                    (*m_pFileStream) << (BYTE) Min((unsigned)nPrecision, 255U);      //Feldlaenge
                     nRecLength = nRecLength + (USHORT)::std::min((USHORT)nPrecision, (USHORT)255UL);
                     (*m_pFileStream) << (BYTE)0;                                                                //Nachkommastellen
                     break;
commit 37c020bc721193a85b659a8f6bda6edcb36759a9
Author: Tor Lillqvist <tlillqvist at novell.com>
Date:   Tue Jan 25 00:46:39 2011 +0200

    No need to define _X86_ and it confuses a 64-bit Windows compilation

diff --git a/connectivity/source/drivers/mozab/makefile_mozab.mk b/connectivity/source/drivers/mozab/makefile_mozab.mk
index bf1ed5b..b7ce6ab 100644
--- a/connectivity/source/drivers/mozab/makefile_mozab.mk
+++ b/connectivity/source/drivers/mozab/makefile_mozab.mk
@@ -56,7 +56,7 @@ MOZINC = . \
         -I$(MOZ_INC)$/uconv \
         -I$(MOZ_INC)$/xpcom_obsolete \
         -I$(MOZ_INC)$/content
-        
+
 .IF "$(GUI)" == "WNT"
   CDEFS +=    \
         -DMOZILLA_CLIENT \
@@ -65,7 +65,6 @@ MOZINC = . \
         -DXP_WIN32 \
         -DOJI \
         -DWIN32 \
-        -D_X86_ \
         -D_WINDOWS \
         -DMOZ_XUL \
         -DMOZ_REFLOW_PERF \


More information about the Libreoffice-commits mailing list