[Libreoffice-commits] .: Branch 'libreoffice-3-4' - sc/inc sc/source

Kohei Yoshida kohei at kemper.freedesktop.org
Mon May 2 15:14:47 PDT 2011


 sc/inc/dptablecache.hxx              |    4 ++--
 sc/source/core/data/dptablecache.cxx |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 1ac4e1f0831f75e0f1813e0e0e699bdb65e42ddd
Author: Kohei Yoshida <kyoshida at novell.com>
Date:   Mon May 2 18:15:14 2011 -0400

    Pass const reference.

diff --git a/sc/inc/dptablecache.hxx b/sc/inc/dptablecache.hxx
index f1934a1..5956623 100644
--- a/sc/inc/dptablecache.hxx
+++ b/sc/inc/dptablecache.hxx
@@ -89,10 +89,10 @@ private:
     mutable ScDPItemDataPool    maAdditionalData;
 
 public:
-    SCROW GetIdByItemData( long nDim,  String sItemData  ) const;
+    SCROW GetIdByItemData( long nDim, const String& sItemData ) const;
     SCROW GetIdByItemData( long nDim, const ScDPItemData& rData ) const;
     
-    SCROW GetAdditionalItemID ( String sItemData ) const;
+    SCROW GetAdditionalItemID ( const String& sItemData ) const;
     SCROW GetAdditionalItemID( const ScDPItemData& rData ) const; 
         
     SCCOL GetDimensionIndex( String sName) const;
diff --git a/sc/source/core/data/dptablecache.cxx b/sc/source/core/data/dptablecache.cxx
index da412db..b468b9f 100644
--- a/sc/source/core/data/dptablecache.cxx
+++ b/sc/source/core/data/dptablecache.cxx
@@ -993,7 +993,7 @@ SCCOL ScDPCache::GetDimensionIndex(String sName) const
     return -1;
 }
 
-SCROW ScDPCache::GetIdByItemData(long nDim, String sItemData ) const
+SCROW ScDPCache::GetIdByItemData(long nDim, const String& sItemData ) const
 {
     if ( nDim < mnColumnCount && nDim >=0 )
     {
@@ -1021,7 +1021,7 @@ SCROW ScDPCache::GetIdByItemData( long nDim, const ScDPItemData& rData  ) const
     return  GetRowCount() + maAdditionalData.getDataId(rData);
 }
 
-SCROW ScDPCache::GetAdditionalItemID ( String sItemData ) const
+SCROW ScDPCache::GetAdditionalItemID ( const String& sItemData ) const
 {
     ScDPItemData rData ( sItemData );
     return GetAdditionalItemID( rData );


More information about the Libreoffice-commits mailing list