[Libreoffice-commits] .: 2 commits - sc/source solenv/gbuild

[Markus Mohrhard]

 sc/source/core/data/document.cxx |    5 -----
 solenv/gbuild/CppunitTest.mk     |    2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 82ceea3903bd361ad97c71a3ab89c7d2a92ec6e9
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Thu Nov 3 02:33:04 2011 +0100

    need to quote command here

diff --git a/solenv/gbuild/CppunitTest.mk b/solenv/gbuild/CppunitTest.mk
index 6d9ce4d..d7911cf 100644
--- a/solenv/gbuild/CppunitTest.mk
+++ b/solenv/gbuild/CppunitTest.mk
@@ -33,7 +33,7 @@
 DBGSV_ERROR_OUT := shell
 export DBGSV_ERROR_OUT
 
-UNIT_FAILED_MSG := echo; echo "Error: a unit test failed, please do one of:"; echo; echo "export DEBUGCPPUNIT=TRUE          \# for exception catching"; echo "export GDBCPPUNITTRACE=gdb --args \# for interactive debugging"; echo "export VALGRIND=memcheck          \# for memory checking" ; echo "and retry."
+UNIT_FAILED_MSG := echo; echo "Error: a unit test failed, please do one of:"; echo; echo "export DEBUGCPPUNIT=TRUE            \# for exception catching"; echo "export GDBCPPUNITTRACE=\"gdb --args\" \# for interactive debugging"; echo "export VALGRIND=memcheck            \# for memory checking" ; echo "and retry."
 
 ifeq ($(strip $(DEBUGCPPUNIT)),TRUE)
 gb_CppunitTest_GDBTRACE := gdb -nx --command=$(SOLARENV)/bin/gdbtrycatchtrace-stdout -return-child-result --args
commit 1c8256c704de6b1f0e81436219a4f4b6a0a87b24
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Wed Nov 2 22:50:45 2011 +0100

    codename is set by ScTabel constructor

diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx
index 196bc17..7dfbd09 100644
--- a/sc/source/core/data/document.cxx
+++ b/sc/source/core/data/document.cxx
@@ -408,7 +408,6 @@ void ScDocument::AppendTabOnLoad(const rtl::OUString& rName)
     if (ValidTab(nTabCount) && ValidNewTabName(rName))
     {
         maTabs.push_back( new ScTable(this, nTabCount, rName) );
-        maTabs[nTabCount]->SetCodeName( rName );
     }
 }
 
@@ -425,7 +424,6 @@ sal_Bool ScDocument::InsertTab( SCTAB nPos, const String& rName,
         if (nPos == SC_TAB_APPEND || nPos >= nTabCount)
         {
             maTabs.push_back( new ScTable(this, nTabCount, rName) );
-            maTabs[nTabCount]->SetCodeName( rName );
             if ( bExternalDocument )
                 maTabs[nTabCount]->SetVisible( false );
         }
@@ -461,7 +459,6 @@ sal_Bool ScDocument::InsertTab( SCTAB nPos, const String& rName,
                 }
 
                 maTabs[nPos] = new ScTable(this, nPos, rName);
-                maTabs[nPos]->SetCodeName( rName );
 
                 // UpdateBroadcastAreas must be called between UpdateInsertTab,
                 // which ends listening, and StartAllListeners, to not modify
@@ -514,7 +511,6 @@ bool ScDocument::InsertTabs( SCTAB nPos, const std::vector<rtl::OUString>& rName
             for ( SCTAB i = 0; i < nNewSheets; ++i )
             {
                 maTabs.push_back( new ScTable(this, nTabCount + i, rNames.at(i)) );
-                maTabs[nTabCount+i]->SetCodeName( rNames.at(i) );
                 if ( bExternalDocument )
                     maTabs[nTabCount+i]->SetVisible( false );
             }
@@ -548,7 +544,6 @@ bool ScDocument::InsertTabs( SCTAB nPos, const std::vector<rtl::OUString>& rName
                 for (SCTAB i = 0; i < nNewSheets; ++i)
                 {
                     maTabs[nPos + i] = new ScTable(this, nPos + i, rNames.at(i));
-                    maTabs[nPos + i]->SetCodeName( rNames.at(i) );
                 }
 
                 // UpdateBroadcastAreas must be called between UpdateInsertTab,