[Libreoffice-commits] .: 2 commits - sdext/source

Tor Lillqvist tml at kemper.freedesktop.org
Tue Oct 4 07:12:24 PDT 2011


 sdext/source/pdfimport/tree/treevisiting.hxx        |    1 +
 sdext/source/presenter/PresenterBitmapContainer.cxx |    1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1e085b43c14c8c67f3c46905eb1a8a528b900e59
Author: Tor Lillqvist <tlillqvist at suse.com>
Date:   Tue Oct 4 16:27:13 2011 +0300

    WaE: class has virtual functions, but destructor is not virtual

diff --git a/sdext/source/pdfimport/tree/treevisiting.hxx b/sdext/source/pdfimport/tree/treevisiting.hxx
index b62340a..73b3f24 100644
--- a/sdext/source/pdfimport/tree/treevisiting.hxx
+++ b/sdext/source/pdfimport/tree/treevisiting.hxx
@@ -63,6 +63,7 @@ namespace pdfi
         virtual void visit( ImageElement&, const std::list< Element* >::const_iterator&  ) = 0;
         virtual void visit( PageElement&, const std::list< Element* >::const_iterator&  ) = 0;
         virtual void visit( DocumentElement&, const std::list< Element* >::const_iterator&  ) = 0;
+        virtual ~ElementTreeVisitor() = 0 { };
     };
     typedef boost::shared_ptr<ElementTreeVisitor> ElementTreeVisitorSharedPtr;
 
commit 028c275a07b9ec130694cbdd15e93ae193097c21
Author: Tor Lillqvist <tlillqvist at suse.com>
Date:   Tue Oct 4 16:14:21 2011 +0300

    WaE: unreachable code

diff --git a/sdext/source/presenter/PresenterBitmapContainer.cxx b/sdext/source/presenter/PresenterBitmapContainer.cxx
index 1422ac3..2084bca 100644
--- a/sdext/source/presenter/PresenterBitmapContainer.cxx
+++ b/sdext/source/presenter/PresenterBitmapContainer.cxx
@@ -452,7 +452,6 @@ css::uno::Reference<css::rendering::XBitmap>
         case Mask:
             return mxMaskBitmap;
     }
-    return NULL;
 }
 
 


More information about the Libreoffice-commits mailing list