[Libreoffice-commits] .: sc/qa

Markus Mohrhard mmohrhard at kemper.freedesktop.org
Fri Oct 7 17:25:34 PDT 2011


 sc/qa/unit/filters-test.cxx |   14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

New commits:
commit 72d87e2b5f37c639c04a1da80b922ae38537d591
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Sat Oct 8 01:37:18 2011 +0200

    improve error messages for sc's filters-test

diff --git a/sc/qa/unit/filters-test.cxx b/sc/qa/unit/filters-test.cxx
index 4a56ce1..525a917 100644
--- a/sc/qa/unit/filters-test.cxx
+++ b/sc/qa/unit/filters-test.cxx
@@ -102,7 +102,9 @@ void testFile(rtl::OUString& aFileName, ScDocument* pDoc, SCTAB nTab, StringType
     catch (const orcus::csv_parse_error& e)
     {
         std::cout << "reading csv content file failed: " << e.what() << std::endl;
-        CPPUNIT_ASSERT_MESSAGE("csv parser error", false);
+        rtl::OStringBuffer aErrorMsg("csv parser error: ");
+        aErrorMsg.append(e.what());
+        CPPUNIT_ASSERT_MESSAGE(aErrorMsg.getStr(), false);
     }
 }
 
@@ -124,7 +126,9 @@ void testCondFile(rtl::OUString& aFileName, ScDocument* pDoc, SCTAB nTab)
     catch (const orcus::csv_parse_error& e)
     {
         std::cout << "reading csv content file failed: " << e.what() << std::endl;
-        CPPUNIT_ASSERT_MESSAGE("csv parser error", false);
+        rtl::OStringBuffer aErrorMsg("csv parser error: ");
+        aErrorMsg.append(e.what());
+        CPPUNIT_ASSERT_MESSAGE(aErrorMsg.getStr(), false);
     }
 
 }
@@ -153,7 +157,7 @@ public:
      */
     void testCVEs();
 
-    //ods filter tests
+    //ods, xls, xlsx filter tests
     void testRangeName();
     void testContent();
     void testFunctions();
@@ -597,7 +601,7 @@ void ScFiltersTest::testStarBasic()
     double aValue;
     pDoc->GetValue(0,0,0,aValue);
     std::cout << aValue << std::endl;
-    CPPUNIT_ASSERT_MESSAGE("",aValue==2);
+    CPPUNIT_ASSERT_MESSAGE("script did not change the value of Sheet1.A1",aValue==2);
     xDocSh->DoClose();
 }
 
@@ -630,7 +634,7 @@ void ScFiltersTest::testVba()
     double aValue;
     pDoc->GetValue(0,0,0,aValue);
     std::cout << aValue << std::endl;
-    CPPUNIT_ASSERT_MESSAGE("",aValue==2);
+    CPPUNIT_ASSERT_MESSAGE("script did not change the value of Sheet1.A1",aValue==2);
     xDocSh->DoClose();
 }
 


More information about the Libreoffice-commits mailing list