[Libreoffice-commits] .: svtools/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Oct 12 03:39:02 PDT 2012


 svtools/source/control/inettbc.cxx  |    1 -
 svtools/source/dialogs/filedlg2.cxx |    9 +++------
 2 files changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 49ebf4f91d14af51bc3772c675de19b5891e3d36
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Oct 12 11:38:40 2012 +0100

    loplugin: unused string and misleading if/else indent
    
    Change-Id: Idd0c4195e5988b3a0ee64282463db44e43d0c597

diff --git a/svtools/source/control/inettbc.cxx b/svtools/source/control/inettbc.cxx
index b0d80e7..490a818 100644
--- a/svtools/source/control/inettbc.cxx
+++ b/svtools/source/control/inettbc.cxx
@@ -725,7 +725,6 @@ void SvtURLBox::TryAutoComplete( sal_Bool bForce )
 {
     if( Application::AnyInput( VCL_INPUT_KEYBOARD ) ) return;
 
-    String aMatchString;
     String aCurText = GetText();
     Selection aSelection( GetSelection() );
     if( aSelection.Max() != aCurText.Len() && !bForce )
diff --git a/svtools/source/dialogs/filedlg2.cxx b/svtools/source/dialogs/filedlg2.cxx
index 2e13038..b5b2dfd 100644
--- a/svtools/source/dialogs/filedlg2.cxx
+++ b/svtools/source/dialogs/filedlg2.cxx
@@ -316,13 +316,11 @@ IMPL_LINK( ImpPathDialog, ClickHdl, Button*, pBtn )
             }
         }
     }
-    else
-    if ( pBtn == pCancelBtn )
+    else if ( pBtn == pCancelBtn )
     {
         GetPathDialog()->EndDialog( sal_False );
     }
-    else
-    if ( pBtn == pHomeBtn )
+    else if ( pBtn == pHomeBtn )
     {
         ::rtl::OUString aHomeDir;
         osl::Security aSecurity;
@@ -336,8 +334,7 @@ IMPL_LINK( ImpPathDialog, ClickHdl, Button*, pBtn )
             }
         }
     }
-    else
-    if ( pBtn == pNewDirBtn )
+    else if ( pBtn == pNewDirBtn )
     {
         DirEntry aFile( pEdit->GetText() );
         if( ! aFile.Exists() && ! FileStat( aFile ).IsKind( FSYS_KIND_WILD ) )


More information about the Libreoffice-commits mailing list