[Libreoffice-qa] ESC meeting minutes: 2023-09-28

Miklos Vajna vmiklos at collabora.com
Thu Sep 28 14:55:06 UTC 2023


* Present:
     + Cloph, Caolan, Eike, Gabriel, Heiko, Hossein, Ilmari, Michael W, Michael S, Olivier, Stephan, Stephane, Thorsten, Xisco, Miklos, Khaled

* Completed Action Items:

* Pending Action Items:
     + Try gtk4 local builds, Qt6 local builds (Cloph)
     + review bot: ignore distro branches when adding reviewers (Xisco)

* Release Engineering update (Cloph)
     + new releases were announced on Tue (7.5.7 & 7.6.2)
       + Xisco will follow-up on the QA list
       + other outdated libraries? (Xisco)
         + Michael S does a lot of work here (Caolan)
     + 7.6 status: 7.6.3 rc1 in 5 weeks
       + no urgent issue from the QA point of view (Xisco)
     + 7.5 status: 7.5.8 rc1 in 2 weeks
     + Xisco rebuilt releases for apple silicon with the old toolchain on macOS
       + Cloph has a patch in gerrit to use the old linker

* Documentation (Olivier)
     + New Help
        + Fix matomo/piwik unnecessary script for local Help (ohallot)
     + Helpcontents2
        + More fixes for menus and UNO commands (ohallot)
        + Updates and fixes (stragu, ohallot, S. Chaiklin, G. Kelemen...)
        + the restored single-HTML export from Impress will also need help pages (Xisco)
          + the core part is restored, to be checked if the help has to be restored as well
     + Guides
        + Bookshelf entries for for FR, NL (ohallot)

     + Bugzilla Documentation statistics
         272(272) bugs open
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
            created     6(2)     19(2)      70(1)      298(0)
          commented     6(0)     48(-9)    225(-12)   1079(-15)
           resolved     0(-2)     4(-1)     30(0)      163(-2)
     + top 10 contributors:
           Stéphane Guillou made 16 changes in 1 month, and 341 changes in 1 year
           Olivier Hallot made 13 changes in 1 month, and 440 changes in 1 year
           Ilmari Lauhakangas made 8 changes in 1 month, and 114 changes in 1 year
           Nabet, Julien made 8 changes in 1 month, and 39 changes in 1 year
           aswath t made 5 changes in 1 month, and 5 changes in 1 year
           Jim Avera made 5 changes in 1 month, and 5 changes in 1 year
           steve made 4 changes in 1 month, and 18 changes in 1 year
           Seth Chaiklin made 4 changes in 1 month, and 306 changes in 1 year
           Vernon, Stuart Foote made 3 changes in 1 month, and 44 changes in 1 year
           Heiko Tietze made 2 changes in 1 month, and 107 changes in 1 year

* UX Update (Heiko)
     + Bugzilla (topicUI) statistics
         259(259) (topicUI) bugs open, 57(57) (needsUXEval) needs to be evaluated by the UXteam
     + Updates:
         BZ changes   1 week   1 month   3 months   12 months
              added      3(2)     14(4)     20(4)       45(2)
          commented     27(-3)   181(-3)   461(15)    2324(-7)
            removed      0(0)      0(0)      1(-1)      20(-4)
           resolved     10(7)     35(5)     86(9)      330(2)
     + top 10 contributors:
           Heiko Tietze made 114 changes in 1 month, and 1385 changes in 1 year
           Stéphane Guillou made 45 changes in 1 month, and 468 changes in 1 year
           Eyal Rozenberg made 41 changes in 1 month, and 324 changes in 1 year
           Kaganski, Mike made 29 changes in 1 month, and 144 changes in 1 year
           Dieter made 20 changes in 1 month, and 247 changes in 1 year
           Vernon, Stuart Foote made 19 changes in 1 month, and 405 changes in 1 year
           ady made 18 changes in 1 month, and 110 changes in 1 year
           Fortin Tam, Jean-François made 11 changes in 1 month, and 16 changes in 1 year
           Bogdan B made 10 changes in 1 month, and 105 changes in 1 year
           neil made 10 changes in 1 month, and 10 changes in 1 year
     + [Bug 157472] Always show menu icons in GTK3_KDE5
     + [Bug 157467] Area background: right-clicking on image to delete or rename
            should target the clicked one and not the selected one
     + [Bug 157234] Should "Consider wrapping styles when positioning objects"
            be ON as default?
     + [Bug 156674] UI: formula help still displayed when editing cell formatted as text
     + [Bug 157438] Expert config: Lists should be properly editable
     + [Bug 157435] Use numeric field when editing integer typed config items
     + [Bug 157436] Expert config: Enumerations should be editable in a dropdown
     + [Bug 157432] Expert config: Allow filtering by changed values
     + [Bug 157439] Properties sidebar deck Position & Size doesn't have
            position controls
     + [Bug 157406] Writer allows to insert comments in footnotes in DOCX,
            but loses them
     + [Bug 157385] [Enhancement] Allow users to put navigator deck and tabbar
            at the top or bottom of the window.
  -> + [Bug 68573] FORMATTING:Inconsistent underlining of text in different
            fonts (see comment 6)
     + [Bug 157276] [UI] Presenter mode does not use system font
     + [Bug 157415] Import & Export mechanism for the font substitution table
     + [Bug 118866] EDITING Hyperlink to hidden sheet navigates to wrong sheet

  -> + The UI/UX aspect of how to deal with security vulnerabilities;
       the question of whether LO should "call home" to check for
       advisories for security-related updates; annoyance of asking for
       consent vs. the responsibility of caring for user security; the
       space of UI choices regarding such security-update-checks.
       + proposal is to show an infobar if it's urgent to update (Heiko)
         + with the possibility to ignore this
       + started to spec out the automatic updater, it'll solve this (Thorsten)
       + usually we don't announce a new release & say it contains a security fix (Cloph)
         + frequently the sec issue is under embargo while releasing
         + also not a fan of phoning home
       + if we want to be more safer than the competition, we may want to have this (Heiko)
         + the webp case is not the usual flow (Cloph)
         + any drawbacks to having a communication channel to signal important updates? (Hossein)
           + yes, privacy. there is always a balance there (Cloph)
       + it's weird with sec updates (Thorsten)
         + the lib severity vs what it means for LO may be different
         + web browser exploit -> may not affect LO
         + almost every release ships a sec fix
         + the real problem is not updating automatically on Windows
         + end users hate changes, they like to stick to old versions (Heiko)
         + visible in the crashreports, people use old versions (Cloph)
         + sure, no problem if you want to disable updates for whatever reason (Thorsten)

* Crash Testing (Caolan)
     + 22(+0) import failure, 0(+0) export failures
        + Armin has some promising pending fixes there, it seems
     + 1,368 coverity issues
       - c++20 baseline, so bumped compiler
       - thought I'd bump coverity version too
         + will find out if older coverity version will work
           with newer compiler and use that instead if possible
     + 2 ossfuzz issues, no crashes

* Crash Reporting (Xisco)
    + https://crashreport.libreoffice.org/stats/version/7.5.6.2
          + (+295) 427 132 0
    + https://crashreport.libreoffice.org/stats/version/7.5.7.1
          + (+38) 38 0
    + https://crashreport.libreoffice.org/stats/version/7.6.0.3
          + (-389) 1226 1615 1923 440 0
    + https://crashreport.libreoffice.org/stats/version/7.6.1.2
          + (+1792) 1792 0
    + https://crashreport.libreoffice.org/stats/version/7.6.2.1
          + (+106) 106 0


     + Fixes in 7.6.2.1 compared to 7.6.0.3

- comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing(unsigned int, com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&)
     - Thanks to Michael Weghorn, had 2000+ reports for this in the past
     - How do you identify the fix for the crash? (Caolan)
       - looking at the git log, trying to guess from that (Xisco)
- static void comphelper::OInterfaceContainerHelper4<com::sun::star::document::XDocumentEventListener>::forEach<<lambda_10c26e3c2930b00cece84fedc26ee250> >(class std::unique_lock<std::mutex> & const, const class `anonymous-namespace'::SfxGlobalEvents_Impl::
     - Thanks to Michael Weghorn
     - was interested in the fix for this, will look in git (Caolan)
- SwModule::ConfigurationChanged(utl::ConfigurationBroadcaster *,ConfigurationHints)
     - Thanks to Paris Oplopoios
- SalInstanceTreeView::get_drag_source()
     - Thanks to Caolán


* Mentoring (Hossein)
           committer...   1 week     1 month      3 months     12 months
                   open      45(-10)     97(-7)      156(-7)       209(-2)
                reviews     226(-42)   1236(-140)   3408(-12)    11502(4)
                 merged     169(-25)    989(-78)    3080(-107)   12609(-110)
              abandoned       4(-6)      60(-9)      142(-10)      634(-15)
            own commits      99(34)     657(-17)    2062(13)      9688(-75)
         review commits      35(17)     179(-38)     628(0)       3025(1)
         contributor...   1 week     1 month      3 months     12 months
                   open      26(5)       56(11)       91(15)       117(16)
                reviews     498(-44)   2290(-194)   7130(-202)   30546(-308)
                 merged      13(8)       62(-25)     220(3)       2165(-41)
              abandoned      14(7)       33(10)      205(11)       625(7)
            own commits      18(15)      62(-12)     221(15)      1099(17)
         review commits       0(0)        0(0)         0(0)          0(0)
     + easyHack statistics:
        needsDevEval 8(8)   needsUXEval 1(1)   cleanup_comments 323(323)
        total 398(398)   assigned 24(24)   open 349(349)
     + top 10 contributors:
           Stéphane Guillou made 6 patches in 1 month, and 35 patches in 1 year
           Srebotnjak, Martin made 4 patches in 1 month, and 20 patches in 1 year
           Sahil Gautam made 4 patches in 1 month, and 9 patches in 1 year
           Adam Seskunas made 4 patches in 1 month, and 4 patches in 1 year
           Dan Horák made 4 patches in 1 month, and 4 patches in 1 year
           Bogdan B made 3 patches in 1 month, and 97 patches in 1 year
           Priyadarshi, Apurva made 2 patches in 1 month, and 2 patches in 1 year
           Montane, Joan made 2 patches in 1 month, and 2 patches in 1 year
           Bayram Çiçek made 2 patches in 1 month, and 2 patches in 1 year
           Ismael Olea made 2 patches in 1 month, and 2 patches in 1 year
     + top 10 reviewers:
           Caolán McNamara made 152 review comments in 1 month, and 538 in 1 year
           Xisco Fauli made 94 review comments in 1 month, and 758 in 1 year
           Thorsten Behrens made 90 review comments in 1 month, and 462 in 1 year
           Michael Stahl made 86 review comments in 1 month, and 1144 in 1 year
           Ilmari Lauhakangas made 76 review comments in 1 month, and 398 in 1 year
           Nabet, Julien made 72 review comments in 1 month, and 962 in 1 year
           Christian Lohmaier made 72 review comments in 1 month, and 408 in 1 year
           Vajna, Miklos made 70 review comments in 1 month, and 894 in 1 year
           Kaganski, Mike made 58 review comments in 1 month, and 360 in 1 year
           Hossein made 58 review comments in 1 month, and 280 in 1 year
     + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
           Ankit Kumar Jaipuriar
           Priyadarshi, Apurva
           t-aswath
           Cosmin Humeniuc (1&1)
           Mihai Vasiliu
   + working on the contents for the workshop
     + had "Intoduction to LibreOffice development" workshop at the conference
     + will prepare certificates for attending people
     + last item was the overview of Writer -> Hossein also talked about his own bugfixes
   + recordings (Gabriel)
     + sadly they are really bad
     + we decided at the last moment that it'll be recorded, wasn't planned
     + significant parts are missing
     + in many cases you can't see which slide is presented
     + sound is OK
     + but still, many missing parts
     + is there still interest in sharing the recording?
       + please share it with me, perhaps will re-record in shorter form (Hossein)
       + where to upload? (Gabriel)
         + perhaps TDF nextcloud (Hossein)
     + I'm planning to do a proper recording of my Bugzilla session too. (Stéphane)
     + yes, re-recording sessions is a good idea (Hossein)
       + could form a course
       + would provide an overview

* Outreachy (Ilmari)
   + https://www.outreachy.org/ -- Applied with two intern slots
   + Mentor sign up deadline September 29: looking for mentors
     + https://www.outreachy.org/communities/cfp/libreoffice/
     + if you have time to mentor & idea: please speak up now
   + Project timeline is Dec -> March
   + Not looking for mentors at this stage, have 2 projects already
   + Michael W also signed up as mentor
   + Activity will start in December
   + Will drop this section next week

* Commit Access
   + Skyler Grey (Miklos)
     + propose to restirct this to direct commit to distro branches
     + follows what we had so far (Cloph)
=> no objections
AI: Miklos to send the welcome mail + point out the restricted scope (Miklos)
AI: Cloph to enable the commit bit (Cloph)

* Developer Certification (Stephan/Miklos/Thorsten/László)
   + resting since: 0 weeks (limit: 20 weeks)
   + new certified developer: Hossein

* Jenkins / CI update (Cloph)
gerrit_android_aarch64     jobs: 117 ok: 109 ko:   3 fail ratio: 2.56% mean_ok:   9 ( 16) median_ok:   7 ( 13)
gerrit_android_arm         jobs: 119 ok: 116 ko:   1 fail ratio: 0.84% mean_ok:   9 ( 16) median_ok:   7 ( 12)
gerrit_android_x86         jobs: 117 ok: 109 ko:   3 fail ratio: 2.56% mean_ok:   8 ( 15) median_ok:   6 ( 10)
gerrit_android_x86_64      jobs: 119 ok: 115 ko:   1 fail ratio: 0.84% mean_ok:   8 ( 15) median_ok:   6 ( 11)
gerrit_linux_clang_dbgutil jobs: 243 ok: 182 ko:  47 fail ratio: 19.34% mean_ok:  34 ( 40) median_ok:  27 ( 38)
gerrit_linux_gcc_release   jobs: 309 ok: 222 ko:  59 fail ratio: 19.09% mean_ok:  17 ( 20) median_ok:  14 ( 15)
gerrit_mac                 jobs: 237 ok: 204 ko:  14 fail ratio: 5.91% mean_ok:  49 ( 50) median_ok:  43 ( 43)
gerrit_windows             jobs: 242 ok: 185 ko:  36 fail ratio: 14.88% mean_ok:  60 ( 71) median_ok:  49 ( 49)
gerrit_master_ml           jobs: 323 ok: 155 ko: 124 fail ratio: 38.39% mean_ok:  85 ( 85) median_ok:  63 ( 63)
gerrit_master              jobs:  57 ok:  25 ko:  21 fail ratio: 36.84% mean_ok:  67 ( 67) median_ok:  47 ( 47)
gerrit_master_seq          jobs: 266 ok: 130 ko: 103 fail ratio: 38.72% mean_ok:  88 ( 88) median_ok:  66 ( 66)
    + https://dev-www.libreoffice.org/tmp/gerrit_230928.html
    + tests that failed more than twice in last seven days
       4 CppunitTest_sw_mailmerge                gerrit_windows
       4 CppunitTest_vcl_pdfexport                gerrit_linux_gcc_release
       4 JunitTest_chart2_unoapi                gerrit_linux_clang_dbgutil
       6 UITest_sw_fieldDialog                gerrit_linux_clang_dbgutil
       8 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil_branch
       8 CppunitTest_vcl_gtk3_a11y                gerrit_linux_gcc_release
      10 CppunitTest_sw_ooxmlexport13                gerrit_linux_gcc_release
      12 UITest_sw_navigator                gerrit_linux_clang_dbgutil
      16 Killed by the kill-wrapper                gerrit_linux_clang_dbgutil
      18 CppunitTest_vcl_text                gerrit_linux_gcc_release
     + the list looks scary, but it's better than that (Cloph)
       + vcl_text failure was mostly limited to a series of patches updating fonts
       + sw_ooxmlexport13 also limited to iterations of a pending change/larger rework from Noel and a patch series where the bottom one had an issue → not a widespread problem
     + the amount of killed builds is not nice
     + sw_navigator improved, but takes time to get changes rebased
     + 1 windows bot had a leftover process and auto-detection didn't kick in
       + if you see multiple failures on the same bot:
         + disable the bot yourself + notify on #tdf-infra
         + or if no permission -> complain about it on #tdf-infra so we can fix it

* What’s cooking (Miklos)
     + C++20 (Stephan)
       + mostly submitted to master
       + still pending: mass-update of string with the string literals
       + feel free to try C++20 features
       + is that limited to C++ arrays? (Miklos)
         + that's for all places where we build an O(U)String at runtime (Stephan)
         + no need for O(U)StringLiteral anymore
         + the "foo" -> O(U)String magic will go away, it's expensive
         + this rewrite will get rid of the runtime cost
     + multi-page floating tables in Writer, see tdf#157119 for details (Miklos)
     + JDK bump to 17 (Michael W)
         + https://gerrit.libreoffice.org/c/core/+/155827
         + still waiting for some macOS builders to be updated
         + hope to get the last one updated in a few weeks (Cloph)
           + no hurry, can wait (Michael W)
     + Right-to-left math layout and other Math improvements (Khaled)
         + All patches have been merged, basically done (not withstanding the long tail of bug fixes)
     + Drop HTML export wizard in Impress/Draw (Xisco)

         - HTML export filter reduced to just export as a html single-document. Now exporting from the UI behaves the same as when using --convert-to html:"impress_html_Export"

         - initially everything was removed, then hit some pushback

         - a simplified filter is now restored

       + Marina presented about Outreachy wrt Windows installation set (Stephan)

         + not nice if it's not integrated

         + planned to set up some build bot to produce the new packaging and see how that goes (Cloph)

     AI: set up a daily tinderbox for this (Cloph)



* QA update (Xisco)
     + UNCONFIRMED: 1178 (+2)
         + enhancements: 284  (+5)
         + needsUXEval: 6 (+1)
         + haveBackTrace: 11 (-1)
         + needsDevAdvice: 35 (+1)
         + documentation:  4 (+1)
         + android:  0 (+0)
         + iOS:  0 (+0)
         + Online:  11 (+0)


     + Most pressing bugs:
      New:

     None


     + New high severity bugs of the week:

         + Writer crashes when inserting ODT file containing PDF into table in another ODT doc
             + https://bugs.documentfoundation.org/show_bug.cgi?id=155917
             + Michael S?

         + Crash in: (anonymous namespace)::XFrameImpl::implts_sendFrameActionEvent(com::sun::star::frame::FrameAction const&)
             + https://bugs.documentfoundation.org/show_bug.cgi?id=156648

         + Firebird: Automatic saving of data leads to data loss for all changes after last pressed "Save"
             + https://bugs.documentfoundation.org/show_bug.cgi?id=157237
             + Fixed. The problematic commit was reverted

* QA stats (Stéphane)
     + New QA blog post: https://qa.blog.documentfoundation.org/2023/09/28/a-community-resolving-issues-collaboratively/
     + Updated QA dashboard: https://stragu.shinyapps.io/lo_qa_dashboard/
         + New Meta network visualisation
         + Option to have Meta bubble sizes proportional to open dependents
         + Include average aggregate ranking of Metas
         + Tweaked aggregate rating after LibOCon feedback
         + New "About" tab
         + Easily show only enhancements
         + New QA:needsComment tally chart
     + Interesting reports:
         + Shared XLSX issues: https://bugs.documentfoundation.org/show_bug.cgi?id=100433
         + Bitmap export of selection in Calc is partly shifted: https://bugs.documentfoundation.org/show_bug.cgi?id=134842
     + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
       +123  -19 (-105) overall)
       many thanks to the top bug squashers:
        QA Administrators       16
        Stéphane Guillou (stragu) 10
        Buovjaga                8
        Kira Tubo               7
        ⁨خالد حسني⁩             7
        Heiko Tietze            6
        Julien Nabet            5
        Miklos Vajna            4
        m.a.riosv               4
        BogdanB                 3

     + top 10 bugs reporters:
        Samuel Mehrbrodt (allotropia) 6
        Callegar                2
        Dan Dascalescu          2
        Eyal Rozenberg          2
        Gabor Kelemen (allotropia) 2
        Gabriele Ponzo          2
        Gilward Kukel           2
        Kira Tubo               2
        Mike Kaganski           2
        Paul Millar             2

     + top 10 bugs fixers:
        خالد حسني               6
        Heiko Tietze            4
        Vajna, Miklos           4
        Caolán McNamara         3
        Nabet, Julien           3
        Patrick Luby            3
        Xisco Fauli             2
        Andreas Heinisch        1
        Kaganski, Mike          1
        Michael Stahl           1

     + top 10 bugs confirmers:
        m.a.riosv               20
        Ilmari Lauhakangas      14
        Stéphane Guillou        12
        Heiko Tietze            7
        Raal                    4
        Bogdan B                3
        Dieter                  3
        Kira Tubo               3
        Nabet, Julien           3
        Robert Großkopf         3


* Bisected bugs open: keyword 'bisected'
    + more accurate - down to a single commit.
    + http://bit.ly/2dyIfDy
    +

      done by:
         Kira Tubo              4
         Stéphane Guillou       4
         Ilmari Lauhakangas     2
         Bogdan B               1
         Sophie Sipasseuth      1
         Timur                  1


* Bibisected bugs open: keyword 'bibisected'
    + http://bit.ly/2cSCXlS
    +

      done by:
         Kira Tubo              5
         Bogdan B               4
         Stéphane Guillou       4
         Nabet, Julien          2
         Sophie Sipasseuth      1
         Timur                  1


* all bugs tagged with 'regression'
    + 1207(+22) bugs open of 12824(+33) total 13(+0) high prio.

      done by:
         Kira Tubo             14
         m.a.riosv              2
         Stéphane Guillou       2
         ady                    1
         Bogdan B               1
         Ilmari Lauhakangas     1
         Alex Thurgood          1
         Rafael Lima            1
         Robert Großkopf        1


* ~Component   count net * high severity regressions
    + http://bit.ly/1HWHb3E
      Writer        - 8(+0)
      Calc          - 3(+0)
      LibreOffice   - 1(+0)
      Printing and PDF export - 1(+0)

    by OS:
      All           - 9(+0)
      Linux         - 2(+0)
      Mac OS X      - 0(+0)
      Windows       - 2(+0)


* ~Component   count net * all regressions
    + http://bit.ly/1BUdI8i
      Writer: other            - 418(+5)
      Calc                     - 226(+3)
      Impress                  - 134(+3)
      LibreOffice              - 49(+1)
      Draw                     - 47(+3)
      Crashes                  - 45(+1)
      Base                     - 42(+0)
      Writer: docx filter      - 41(+0)
      Borders                  - 36(+1)
      UI                       - 35(+3)
      Writer: perf             - 33(+0)
      Writer: other filter     - 31(+0)
      Printing and PDF export  - 25(+1)
      RTL                      - 23(+0)
      Chart                    - 22(+0)
      BASIC                    - 17(+0)
      filters and storage      - 17(+1)
      Writer: doc filter       - 15(+0)
      graphics stack           - 12(+0)
      Formula Editor           - 5(+1)
      framework                - 4(+0)
      Extensions               - 2(+0)
      sdk                      - 2(+0)
      Linguistic               - 1(+0)


More information about the Libreoffice-qa mailing list