[Libreoffice-ux-advise] Linking media ...

[Michael Meeks]

Hi guys,

	So - one of the sexy features to hit LibreOffice 3.5 - that (sadly)
hasn't hit the wiki page yet (Michael?)

	http://wiki.documentfoundation.org/ReleaseNotes/3.5

	Is the ability to embed Multimedia (ie. videos & audio) inside ODF
documents :-) that avoids the common problem of posting your slides and
them being missing that data at the other end.

	Unfortunately; the 'Link' option is the default for this media type,
and I was wondering - since that seems (to me) to be mostly a bug ;-)
[ and one we turned off for images by default long ago ] - whether there
would be any objections to:

	* disabling 'link' for multimedia embedding by default
		+ ie. we should embed the file verbatim.
and:
	* throwing up a dialog saying:
		"are you sure you want to embed this big blob"
		+ or similar (bette rtext appreciated)
		+ if the media is greater than some nice number eg. 16Mb

	Interestingly, ~none of the sample videos I deal with are that big -
max 60Mb so perhaps just having the possibility to link and just always
doing it by default is not such a bad idea (?). Thoughts appreciated.

	And Michael - thanks for the lovely feature :-)

	Thanks,

		Michael.

Banal patch to always embed:

diff --git a/avmedia/source/viewer/mediawindow.cxx b/avmedia/source/viewer/mediawindow.cxx
index 713e9e9..4f25672 100644
--- a/avmedia/source/viewer/mediawindow.cxx
+++ b/avmedia/source/viewer/mediawindow.cxx
@@ -311,7 +311,7 @@ bool MediaWindow::executeMediaURLDialog(Window* /* pParent */,
         // for video link should be the default
         xCtrlAcc->setValue(
                 ui::dialogs::ExtendedFilePickerElementIds::CHECKBOX_LINK, 0,
-                uno::makeAny(sal_True) );
+                uno::makeAny(sal_False) );
         // disabled for now: TODO: preview?
         xCtrlAcc->enableControl(
                 ui::dialogs::ExtendedFilePickerElementIds::CHECKBOX_PREVIEW,

-- 
michael.meeks at suse.com  <><, Pseudo Engineer, itinerant idiot