[Libreoffice-ux-advise] [Bug 138857] Make the font replacement table easier to understand

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=138857

Jan-Marek Glogowski <glogow at fbihome.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=13
                   |                            |6534,
                   |                            |https://bugs.documentfounda
                   |                            |tion.org/show_bug.cgi?id=13
                   |                            |8865

--- Comment #3 from Jan-Marek Glogowski <glogow at fbihome.de> ---
While writing my patch I found more problems.

- if I call toString() on an empty OUStringBuffer, LO crashes

Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault.
0x00007ffff7f333a9 in rtl_uString_newFromStr_WithLength (ppThis=0x7fffff7ff0a0,
pCharStr=0x55555ac25018 u"", nLen=0) at sal/rtl/strtmpl.cxx:1367
1367    {
(gdb) bt 10
#0  0x00007ffff7f333a9 in rtl_uString_newFromStr_WithLength
(ppThis=0x7fffff7ff0a0, pCharStr=0x55555ac25018 u"", nLen=0) at
sal/rtl/strtmpl.cxx:1367
#1  0x00007ffff376cb3a in rtl::OUString::OUString (length=<optimized out>,
value=<optimized out>, this=0x7fffff7ff0a0) at include/rtl/ustring.hxx:289
#2  rtl::OUStringBuffer::toString (this=<optimized out>) at
include/rtl/ustrbuf.hxx:541
#3  Edit::GetText (this=<optimized out>) at vcl/source/control/edit.cxx:2580
#4  0x00007ffff376cb00 in Edit::GetText (this=<optimized out>) at
vcl/source/control/edit.cxx:2578
#5  0x00007ffff3a4a575 in SalInstanceComboBoxWithEdit::get_active_text
(this=<optimized out>) at vcl/source/app/salvtables.cxx:6125
#6  0x00007fffa7be5cba in SvxFontSubstTabPage::SelectHdl
(this=this at entry=0x55555c054660, pWin=0x55555c008fb8) at
cui/source/options/fontsubs.cxx:336
#7  0x00007fffa7be58a8 in SvxFontSubstTabPage::CheckEnable
(this=this at entry=0x55555c054660) at cui/source/options/fontsubs.cxx:396
#8  0x00007fffa7be5c00 in SvxFontSubstTabPage::SelectHdl
(this=this at entry=0x55555c054660, pWin=0x55555c008fb8) at
cui/source/options/fontsubs.cxx:349
#9  0x00007fffa7be58a8 in SvxFontSubstTabPage::CheckEnable
(this=this at entry=0x55555c054660) at cui/source/options/fontsubs.cxx:396

I think OUStringBuffer::toString should work with empty strings.

- if I select a line, the first checkbox is toggled on every click (tdf#138865)
- the delete button always refers to the selection and has nothing to do with
that line
- you can add multiple substitution for the same font, which is a unexpected
- selecting multiple entries fills the combo boxes with the first selection

Some of this happens, because tdf#136534 didn't fix all of the wrong text
lookups.

Proposed patch: https://gerrit.libreoffice.org/c/core/+/107642

-- 
You are receiving this mail because:
You are on the CC list for the bug.