[Bug 158101] Disabled popup menu items are visible with non-gtk backend

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=158101

--- Comment #6 from Rafael Lima <rafael.palma.lima at gmail.com> ---
(In reply to Heiko Tietze from comment #5)
> Disabled entries should be shown, hidden not.

The popup menu in the attachment is an XML file with UNO commands (defined in
swriter/popupmenu/text.xml).

AFAIK, we can only enable/disable UNO commands in such menus... there's no way
to hide a UNO command in such menus. At least not in a GetState function.

Also, I have the feeling that over time, devs have always assumed that a
disabled UNO command will be hidden, which is why the text.xml menu is so
gigantic.

If we leave all disabled UNO commands visible, we'll get enormous menus
everywhere, full of disabled items.

(In reply to Jim Raykowski from comment #1)
> Here is a patch that provides gtk context menu behavior for non-gtk backends
> while preserving the intent of the regression causing patch:
> https://gerrit.libreoffice.org/c/core/+/159192

Therefore, I believe the patch proposed by Jim is valid.

-- 
You are receiving this mail because:
You are on the CC list for the bug.