<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"><html><head><meta content="text/html;charset=UTF-8" http-equiv="Content-Type"></head><body ><DIV><FONT face=Verdana,Arial,Helvetica,sans-serif>Hi all,<BR><BR></FONT>It's nice to see how fast this is going :)<BR><BR>I don't understand much of the code, but LO uses those bitmaps and takes the areas which contain the actual icon, right? Wouldn't it be much more convenient to use single (SVG) images instead, or at least a vector-based set of handles?<BR><BR>Thanks for your effort<BR><BR>Alex<BR></DIV>
<DIV id=1><BR>---- On Mon, 31 Oct 2011 18:54:35 +0100 <B>Michael Meeks <<a href='mailto:michael.meeks@suse.com' target='_blank'>michael.meeks@suse.com</a>></B> wrote ---- <BR></DIV><BR>
<BLOCKQUOTE style="PADDING-LEFT: 6px; BORDER-LEFT: #0000ff 1px solid">Hi there, <BR><BR> Last split out mail: <BR><BR>On Mon, 2011-10-31 at 15:28 +0100, Astron wrote: <BR>> Lastly, there's the anchor image from Writer that is also in dire need <BR>> of replacement. <BR><BR> Oooh ! that could be pretty indeed :-) <BR><BR>> What would be great: <BR>> * to know the location of these images in the git repository (sorry, I <BR>> really tried finding them, but there are too many icons) <BR><BR> Not certain, but I tried: <BR><BR>cd sw/ ; git grep ANCHOR <BR>sw/source/ui/utlui/initui.src: BITMAP BMP_FRAME_ANCHOR { FILE = "anchor.bmp" ; }; <BR>sw/source/ui/utlui/initui.src: BITMAP BMP_FRAME_DRAG_ANCHOR { FILE = "danchor.bmp" ; }; <BR><BR> Which looks promising, but in fact both of these images are 'missing <BR>icon' icons ;-) I'll add an easy hack to remove them & associated cruft when I can. <BR><BR> In fact the anchors are in the images attached - which have never been <BR>themed nicely (AFAIK). The second set have been 'improved' a bit, but <BR>its unclear if we use them. It took me about an hour to find the code <BR>(finally from sc/) - the handle object is a: <BR><BR> svx/source/svdraw/svdhdl.cxx <BR><BR> and we create in sc/ with: <BR><BR>rHdl.AddHdl(new SdrHdl(aPos, bNegativePage ? HDL_ANCHOR_TR : HDL_ANCHOR)); <BR><BR> In -theory- we switch between these two different images of anchor at <BR>the cursor blink frequency: <BR><BR>// #98388# when anchor is used take upper left as reference point inside the handle <BR> pRetval = new ::sdr::overlay::OverlayAnimatedBitmapEx(rPos, aBmpEx1, aBmpEx2, nBlinkTime); <BR><BR> But I've (personally) never noticed that - perhaps this is because the <BR>images are so similar ? or possibly it is just broken - possibly <BR>OverlayAnimatedBitmapEx is having a bad year. <BR><BR>> * to know what's possible with these images – most importantly: alpha <BR>> transparency? <BR><BR> So - it -looks- as if all that good stuff is possible. It is entirely <BR>possible / probable that we should rip those anchor icons out of their <BR>sets and enlarge / prettify / alpha-blend them. <BR><BR> It'd be great if you could experiment with using alpha / improving the <BR>look of those in your LibreOffice images*.zip ? <BR><BR>> * if someone could remove the additional UI/code <BR>> * if someone would make them themeable (if they aren't <BR>> already/strictly optional) <BR><BR> So - they are already themable, but (I guess) no-one ever knew how to. <BR>There is also a theme-inside-a-theme of the <BR><BR> sal_Bool bIsFineHdl(pHdlList->IsFineHdl()); <BR><BR> that switches between the two sets; from 'SetFineHdl' only called from: <BR><BR> void SdrMarkView::SetSolidMarkHdl(sal_Bool bOn) <BR><BR> Which seems to be tied to the 'SimpleHandles' config setting, and I guess <BR>the other images in that bitmap are in fact the handles we use to edit line shapes <BR>etc. The question is - do we really want the "simple handles" mode / configuration <BR>option anymore ? it seems redundant to me and the handles look even less pretty. <BR><BR> Thanks for caring about this detail ! <BR><BR> ATB, <BR><BR> Michael. <BR><BR>-- <BR><A href="mailto:michael.meeks@suse.com" target=_blank>michael.meeks@suse.com</A> <><, Pseudo Engineer, itinerant idiot <BR><BR></BLOCKQUOTE><BR></body></html>