<div dir="ltr">Looks great in beta2. Now the popup is in the right location and behaves correctly (testing with pagebreak, header/footer and comments).<br><br><div class="gmail_quote">On Fri, Dec 16, 2011 at 6:04 PM, Cedric Bosdonnat <span dir="ltr"><<a href="mailto:cbosdonnat@suse.com">cbosdonnat@suse.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Lior, all,<br>
<br>
A fix for the RTL PopupButton is landing in master (and soon in 3.5<br>
branch). Don't hesitate to stress it a lot (and not only the Page break<br>
feature as it affects the whole office).<br>
<br>
Here is the commit:<br>
<a href="http://cgit.freedesktop.org/libreoffice/core/commit/?id=f6b679e831ebf4a85b3baf37ea0198959f58fa1f" target="_blank">http://cgit.freedesktop.org/libreoffice/core/commit/?id=f6b679e831ebf4a85b3baf37ea0198959f58fa1f</a><br>
<br>
Regards,<br>
--<br>
Cedric<br>
<div><div class="h5"><br>
On Thu, 2011-12-15 at 11:38 +0200, Lior Kaplan wrote:<br>
> On Thu, Dec 15, 2011 at 11:23 AM, Cedric Bosdonnat<br>
> <<a href="mailto:cbosdonnat@suse.com">cbosdonnat@suse.com</a>> wrote:<br>
> Hi all,<br>
><br>
> Lior reported a problem with the positioning of the page break<br>
> indicators in RTL UI [0]. I can't really find a cool solution<br>
> on how to<br>
> place that control to fit all cases like<br>
> * RTL UI / LTR document<br>
> * RTL UI / RTL document<br>
> * LTR UI / LTR document<br>
> * LTR UI / RTL document<br>
><br>
> In this case, I don't think the directionality of the document is<br>
> relevant, only the UI's directionality, we're talking about two<br>
> options:<br>
> * LTR UI - already done<br>
> * RTL UI - location should be mirrored, as most of the UI elements.<br>
><br>
><br>
> In single page view I don't mind moving the control to the<br>
> right, but<br>
> we'll face problems for book view. We will also have troubles<br>
> with the<br>
> popup menu for LTR document / UI and book mode when the<br>
> control is on<br>
> the right.<br>
><br>
> For book view, the current behavior of the marker location should be<br>
> kept (=<br>
> marker on the right for a right page, marker on the left for a left<br>
> page).<br>
><br>
><br>
> My question for you is when to draw it on what side... and how<br>
> to make<br>
> sure the popup menu never goes outside the Writer window?<br>
><br>
> Can't help you with that, but as it seems that there are calculations<br>
> for the popup menu location for the LTR UI, this should also be done<br>
> in RTL UI (just from the other side of the screen).<br>
><br>
> Lior: the other question for you is: what to do if a document<br>
> mixes RTL<br>
> and LTR paragraphs?<br>
><br>
> As stated above - not relevant, only take UI directionality into<br>
> account.<br>
><br>
> Thanks for investing the time in RTL issues (:<br>
><br>
> Kaplan<br>
><br>
</div></div>> _______________________________________________<br>
> Libreoffice-ux-advise mailing list<br>
> <a href="mailto:Libreoffice-ux-advise@lists.freedesktop.org">Libreoffice-ux-advise@lists.freedesktop.org</a><br>
> <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice-ux-advise</a><br>
<br>
<br>
</blockquote></div><br></div>