<div dir="ltr">Hello,<div> </div><div>Can you guys look at this change and advise whether it's OK from a UX perspective? Thanks! <div class="gmail_quote">---------- Forwarded message ---------- From: Muhammad Haggag (via Code Review) <<a href="mailto:gerrit@gerrit.libreoffice.org">gerrit@gerrit.libreoffice.org</a>> Date: Sat, Nov 24, 2012 at 2:16 PM Subject: [PATCH] fdo#48317 - Support jumping to next/previous change To: Cc: LibreOffice Developer List <<a href="mailto:libreoffice@lists.freedesktop.org">libreoffice@lists.freedesktop.org</a>> Hi, I have submitted a patch for review: <a href="https://gerrit.libreoffice.org/1156" target="_blank">https://gerrit.libreoffice.org/1156</a> To pull it, you can do: git pull ssh://<a href="http://gerrit.libreoffice.org:29418/core" target="_blank">gerrit.libreoffice.org:29418/core</a> refs/changes/56/1156/1 fdo#48317 - Support jumping to next/previous change Added two new writer commands: NextTrackedChange (FN_REDLINE_NEXT_CHANGE) and PreviousTrackedChange (FN_REDLINE_PREV_CHANGE). Rewrote the logic for Accept/Reject change (FN_REDLINE_ACCEPT_DIRECT and FN_REDLINE_REJECT_DIRECT) to work well with the newly introduced commands. Change-Id: I03d583bef4225409f69934f16db1854564c2db5f --- M officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu M scripting/workben/bindings/writermenubar.xml M sw/inc/cmdid.h M sw/inc/swcommands.h M sw/sdi/_viewsh.sdi M sw/sdi/swriter.sdi M sw/source/ui/app/mn.src M sw/source/ui/uiview/view2.cxx M sw/source/ui/uiview/viewstat.cxx M sw/uiconfig/sglobal/menubar/menubar.xml M sw/uiconfig/swform/menubar/menubar.xml M sw/uiconfig/swreport/menubar/menubar.xml M sw/uiconfig/swriter/menubar/menubar.xml M sw/uiconfig/swxform/menubar/menubar.xml 14 files changed, 180 insertions(+), 20 deletions(-) -- To view, visit <a href="https://gerrit.libreoffice.org/1156" target="_blank">https://gerrit.libreoffice.org/1156</a> To unsubscribe, visit <a href="https://gerrit.libreoffice.org/settings" target="_blank">https://gerrit.libreoffice.org/settings</a> Gerrit-MessageType: newchange Gerrit-Change-Id: I03d583bef4225409f69934f16db1854564c2db5f Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Muhammad Haggag <<a href="mailto:mhaggag@gmail.com">mhaggag@gmail.com</a>> _______________________________________________ LibreOffice mailing list <a href="mailto:LibreOffice@lists.freedesktop.org">LibreOffice@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/libreoffice" target="_blank">http://lists.freedesktop.org/mailman/listinfo/libreoffice</a> </div> </div></div>