[Libreoffice] patch review for commit 67be5829944758dec070710521cd86ae49e00aa9

Radek Doulík rodo at novell.com
Thu Dec 2 06:29:17 PST 2010


Hi Thorsten,

would you please review my patch in vcl/source/canvastools? I would like
to push it to 3-3 branch.

Cheers
Radek

commit 67be5829944758dec070710521cd86ae49e00aa9
Author: Radek Doulik <rodo at novell.com>
Date:   Thu Dec 2 15:23:17 2010 +0100

    fix invalid read in doubleSequenceToColor, fixes crash in n#654065

diff --git a/vcl/source/helper/canvastools.cxx b/vcl/source/helper/canvastools.cxx
index 9f701c5..d57c9f4 100644
--- a/vcl/source/helper/canvastools.cxx
+++ b/vcl/source/helper/canvastools.cxx
@@ -820,13 +820,13 @@ namespace vcl
             const uno::Sequence< double >                   rColor,
             const uno::Reference< rendering::XColorSpace >& xColorSpace )
         {
-            const rendering::ARGBColor& rARGBColor(
+            const rendering::ARGBColor aARGBColor(
                 xColorSpace->convertToARGB(rColor)[0]);
 
-            return Color( 255-toByteColor(rARGBColor.Alpha),
-                          toByteColor(rARGBColor.Red),
-                          toByteColor(rARGBColor.Green),
-                          toByteColor(rARGBColor.Blue) );
+            return Color( 255-toByteColor(aARGBColor.Alpha),
+                          toByteColor(aARGBColor.Red),
+                          toByteColor(aARGBColor.Green),
+                          toByteColor(aARGBColor.Blue) );
         }
 
         //---------------------------------------------------------------------------------------





More information about the LibreOffice mailing list