[PATCH 16/16] removing code due to endless loop

Pierre-André Jacquod pjacquod at alumni.ethz.ch
Sat Dec 4 13:05:10 PST 2010


these part of code have been removed. The While(true) loop
means either that the if statement is never taken, or that
the program hangs there. The second case is not safe, the first
case means that this code is not needed.
---
 binfilter/bf_sw/source/core/txtnode/sw_thints.cxx |   23 ---------------------
 1 files changed, 0 insertions(+), 23 deletions(-)

diff --git a/binfilter/bf_sw/source/core/txtnode/sw_thints.cxx b/binfilter/bf_sw/source/core/txtnode/sw_thints.cxx
index 06b91e2..13333ad 100644
--- a/binfilter/bf_sw/source/core/txtnode/sw_thints.cxx
+++ b/binfilter/bf_sw/source/core/txtnode/sw_thints.cxx
@@ -923,16 +923,6 @@ using namespace ::com::sun::star::i18n;
 /*N*/
 /*N*/ 	if( pNd == this )
 /*N*/ 	{
-/*?*/ 		if( aThisSet.Count() )
-/*?*/ 		{
-/*?*/ 			SfxItemIter aIter( aThisSet );
-/*?*/ 			const SfxPoolItem* pItem = aIter.GetCurItem();
-/*?*/ 			while( TRUE )
-/*?*/ 			{
-                    DBG_BF_ASSERT(0, "STRIP"); //STRIP001 /*?*/ 				if( lcl_IsNewAttrInSet( *pSwpHints, *pItem, GetTxt().Len() ) )
-/*?*/ 			}
-/*?*/ 		}
-/*N*/
 /*N*/ 	}
 /*N*/ 	else
 /*N*/ 	{
@@ -947,19 +937,6 @@ using namespace ::com::sun::star::i18n;
 /*N*/ 		{
 /*?*/ 			DBG_BF_ASSERT(0, "STRIP"); //STRIP001 SfxItemIter aIter( aThisSet );
 /*N*/ 		}
-/*N*/
-/*N*/ 		if( aNdSet.Count() )
-/*N*/ 		{
-/*?*/ 			SfxItemIter aIter( aNdSet );
-/*?*/ 			const SfxPoolItem* pItem = aIter.GetCurItem();
-/*?*/ 			while( TRUE )
-/*?*/ 			{
-                    DBG_BF_ASSERT(0, "STRIP"); //STRIP001 /*?*/ 				if( lcl_IsNewAttrInSet( *pNd->pSwpHints, *pItem, pNd->GetTxt().Len() ) )
-/*?*/ 			}
-/*?*/
-/*?*/ 			SwFmtChg aTmp1( pNd->GetFmtColl() );
-/*?*/ 			pNd->SwModify::Modify( &aTmp1, &aTmp1 );
-/*N*/ 		}
 /*N*/ 	}
 /*N*/
 /*N*/ 	if( pNd->pSwpHints->CanBeDeleted() )
-- 
1.7.1


--------------070900090301010006010400--


More information about the LibreOffice mailing list