[Libreoffice] [PUSHED] Re: [PATCH] SAL_PRIxUINT32 instead of bare %x

Caolán McNamara caolanm at redhat.com
Fri Dec 10 12:22:32 PST 2010


On Sat, 2010-12-11 at 00:25 +0900, Takeshi Abe wrote:
> Hi,
> 
> I got a following warning in the build of sw:
> ---
> Compiling: sw/source/filter/ww8/ww8par.cxx
> /home/tabe/libo/clone/writer/sw/source/filter/ww8/ww8par.cxx: In member function 'virtual void Sttb::Print(FILE*)':
> /home/tabe/libo/clone/writer/sw/source/filter/ww8/ww8par.cxx:216: warning: format '%x' expects type 'unsigned int', but argument 3 has type 'sal_uInt32'
> ---
> 
> The attached one just suppresses it.

Yup, good stuff. Pushed this now. Thanks.

FWIW I build with ./autogen.sh --enable-werror which makes all warnings
as errors (except in binfilter and lotuswordpro). But seeing as I'm
under x86_64 the above didn't trigger a warning on 64bit given that
sal_Int32 is defined as int there, while as long on x86.

C.



More information about the LibreOffice mailing list