[Libreoffice] sw: numbering misbehaviour

[Caolán McNamara]

On Tue, 2010-12-21 at 11:16 -0800, Octavio Alvarez wrote:
> On Mon, 20 Dec 2010 02:06:01 -0800, Caolán McNamara <caolanm at redhat.com>
> wrote:
> 
> > On Sun, 2010-12-19 at 01:16 +0000, Wols Lists wrote:
> >> Note that I'm not used to bullets etc BUT. In WordPerfect when you
> >> select text and format it it puts on/off markers round the text. Hitting
> >> "end" takes you PAST those markers. So you *have* just told it to go
> >> back to the defaults!
> >
> > The equivalent in writer was originally to press the right arrow when
> > you are already at the end of the line. I see that this is still
> > documented as such in help, but was changed long ago to be ctrl+shift+x
> 
> Technically, that doesn't make it "move past the ending marker", but
> "removes the direct character formatting" (at least according to
> Tools » Customize)

True, FWIW the relevant change for the right-arrow was back around
http://qa.openoffice.org/issues/show_bug.cgi?id=13592 where the right
arrow thing got dropped. The outcome is sort of the same though.

> To move past the last ending marker (there might be more than one) we
> need to set the current character style to "Default" instead of simply
> removing hard format.

> I would have expected this to break after commit 985b180a2 on
> libreoffice/writer, but looks like it detects it and it actually applies
> Default instead if the cursor is at the end of the paragraph.


> Interestingly enough, this does not happen at the beginning of the
> paragraph. Should it? (Even if you manually set Default, it doesn't
> work.)

Hum, a little bit of a mess I guess. I suppose we need to decide what we
want to happen, and I missed out on the earlier discussions about this.
so here's what we've got at the moment I think ?

a) Ctrl+shift+x is bound to "Remove Direct Character formatting" and
affects just character formatting.
b) Ctrl+M is bound to "Default Formatting" and affects all formatting,
including paragraph stuff
c) We don't have a "Remove Character formatting" which would strip off
character formatting + character styles.

Where "Direct character formatting" is character "formatting that you
applied without using styles" and

"Default Formatting" is documented to be "Remove direct formatting and
formatting by character styles from the selection".

So what I would expect then is that "Remove direct character formatting"
should remove character formatting that is not part of a style. So
something that has a character style applied to it should retain that
character style after "remove direct character formatting" is used.

And what I would expect "Default formatting" to do is to remove the
character style as well.

Which would suggest, if we like that logic so far, is that

a) At the moment ctrl+shift+x at the end of a line that is currently all
set to "emphasis" will from that point onwards be reset to "Default". So
that'd be a bug under the above rules, because "remove direct
formatting" shouldn't remove character styles. Which would suggest that
not working at the start of a line (or anywhere else in it) is ok.
b) ctrl+m at the moment at the end of a line that is currently all set
to "emphasis" resets from there onwards to be "Default" which is ok as
it's supposed to remove character styles. Its failure to do so at the
start or anywhere else in a line would be a bug in that case.
c) If you set the first few words of a paragraph to "emphasis", and then
double click the character style of "Default" when in the second word
then that word changes to "Default", good. But if the cursor is at the
start of the first word then the word remains as "emphasis", though the
style navigator incorrectly claims it as "default" which is a related
nuisance.

C.