[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro 7

Caolán McNamara caolanm at redhat.com
Tue Nov 2 14:13:01 PDT 2010


On Tue, 2010-11-02 at 18:44 +0100, Gert Faller wrote:
> Hi,
> 
> with this one, module 'impress' should be rather clean of that.

Heh, good, liked the ? : rework to keep me pacified :-). Thanks for
this.

As an aside, stylistically I'd prefer
rtl::OUString sFoo(RTL_CONSTASCII_USTRINGPARAM("apple"));
over
rtl::OUString sFoo(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("apple")));
or
rtl::OUString sFoo =
    rtl::OUString(RTL_CONSTASCII_USTRINGPARAM("apple"));
even though they're all exactly equivalent, shorter text and more
direct, so I modified a few of those in passing while committing this.

C.



More information about the LibreOffice mailing list