[Libreoffice] [PATCH] Convert --enable-java to --with-java

Wols Lists antlists at youngman.org.uk
Fri Nov 5 02:43:07 PDT 2010


On 05/11/10 07:42, Sebastian Spaeth wrote:
> On Thu, 04 Nov 2010 18:24:04 +0000, Wols Lists  wrote:
>> +  --with-java             Build LibO with a JDK & Java support.],
> So, what should be the default? Including Java? Then I would argue for
> making this a --without option and having Java enabled by default... ?
I'll check to see what exactly is in the make system.  What I did was
look to see if enable-java was used anywhere (it isn't), and just change
it to with-java so the macro definition (a) matched the documentation,
and (b) matched what the rest of the build system used.

In other words, this patch is a "do nothing bug fix" and should be safe
"as is". Your suggestion is actually a functional change so yes, it
makes sense, but imho it should be a separate patch.

Cheers,
Wol


More information about the LibreOffice mailing list