[Libreoffice] [PUSHED] Re: [PATCH] RTL_CONSTASCII_USTRINGPARAM for libs-core/fpicker

Caolán McNamara caolanm at redhat.com
Sat Nov 20 09:23:19 PST 2010


On Sat, 2010-11-20 at 17:50 +0100, Julien Nabet wrote:
> Hello,
> 
> Here's a patch for libs-core/fpicker

Looks all good. Thanks for this.

I did leave out the changes inside the VISTAFILEDIALOG_CHECKED_COMCALL
macro.

as its inside a define where the parameter is passed into it, so it
can't be guaranteed to be a literal. 

As an aside though, nothing in LibreOffice itself appears to use
"VISTAFILEDIALOG_CHECKED_COMCALL", so I wonder if it can be removed
entirely. Though maybe "VISTAFILEDIALOG_CHECKED_COMCALL" called via some
other strange windows programming specific magic. 

C.




More information about the LibreOffice mailing list