[Libreoffice] [PUSHED] Re: [PATCH] And another one

Caolán McNamara caolanm at redhat.com
Mon Nov 29 12:04:29 PST 2010


On Mon, 2010-11-29 at 16:56 +0000, Wols Lists wrote:
> That's all of base scanned. Unless I've missed something (and I've
> deliberately skipped a few bits, eg that marked with TODO), there
> shouldn't be any dead code or end-of-if/end-of-switch type comments left

There's another, (in my opinion more interesting), class of dead-code
and that's the stuff that's compiled in but isn't called by anything.

I've yet to get in gear and get up-to-date runs for LibreOffice, but see
http://people.redhat.com/caolanm/callcatcher/DEV300_m87/ for my last OOo
callcatcher run. e.g. approx 170 apparently juicy unused methods in
calc.

Though caveats apply and manual double checking is required to see why
nothing calls them. They might be called only under some ifdefs, or by
some tricky means like dlopen/dlsym (which is only likely to happen for
C symbols and not C++ symbols, noone in their right mind dlsyms 

C.



More information about the LibreOffice mailing list