[Libreoffice] [PUSHED] Re: [PATCH] Easy Hacks : Use RTL_CONSTASCII_USTRINGPARAM macro

Caolán McNamara caolanm at redhat.com
Sat Oct 30 08:59:34 PDT 2010


On Sat, 2010-10-30 at 17:08 +0200, Gert Faller wrote:
> Hi,
> a first try on that.

Excellent, these are little mini-optimizations and they all help.

> Not sure if I let the original source (for control)

Nah, don't bother keeping the old content as a comment, we can look at
the git history to see what it was previously if its necessary to do so.
So I stripped those from the patch.

You have two typos in there however, i.e.

- com.sun.star.chart.BarDiagram
+ com.sun.star.chart.BarDiagra

- com.sun.star.chart2.ScatterChartType
+ com.sun.star.chart2.ScatterChartTyp

in those two cases the trailing letter of the original string got
removed !, eek that was close ;-). So I fixed up those two and
committed and pushed this change. Thanks.

C.



More information about the LibreOffice mailing list