[Libreoffice] [PATCH] Only accelerators in Edit popup on Windows and KDE

[Christian Dywan]

Am 19.04.2011 13:30:25 schrieb libreoffice at lists.freedesktop.org:
>  On 2011-04-15 at 12:48 +0000, Christian Dywan wrote: 
>  > I'm not sure if this is the best way to address this, I looked at the 
>  > style settings, but this isn't a setting, and I saw get_desktop_session() but that isn't public API and I'm not 
> > sure how it's meant to be used. If there's a better approach, pointers welcome. 
>  Nice, thank you very much for the patch! :-) The best is to use 
>  Application::GetDesktopEnvironment(), like eg. here: 
>    
> http://opengrok.libreoffice.org/xref/components/cui/source/options/optgdlg.cxx#129 
>  [without the #ifdefs etc. - here you don't care whether the plugin is available, or not ;-)]
> Can you please update it? 

Nice, that's exactly the API I was looking for but didn't find before. Thanks!

Updated the patch.


> Am 19.04.2011 13:35:54 schrieb Lubos Lunak:
> I think it makes more sense to have it as a style setting rather than hardcoding a bunch of if's

I don't think it makes sense as a setting, and no platform has a setting for this afair.

SetAccelKey applies to all menus if I understand correctly, but the distinction is for context menues as opposed to the menubar.

ciao,
    Christian
            
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Only-accelerators-in-Edit-popup-on-Windows-and-KDE.patch
Type: text/x-patch
Size: 2260 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110419/c1fdd059/attachment.bin>