[Libreoffice] [PUSHED] Allow GoUpSel, GoDownSel, GoLeftsel, GoRightSel to use "By" property

Kohei Yoshida kohei.yoshida at suse.com
Wed Aug 10 14:25:38 PDT 2011


Hi Olivier,

Good catch for this.

On Wed, 2011-08-10 at 18:06 -0300, Olivier Hallot wrote:

> I had to add this patch to prevent the table boudaries crash issue
> that raised when one use the By property for GoLeftSel and GoRightSel.

I would put the boundary check before incrementing and decrementing the
column / row position, to be consistent with the previous if statement
which checks the next position before moving the position, not after.

So, attached is my proposed change.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc
<kohei.yoshida at suse.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: what-I-would-do.diff
Type: text/x-patch
Size: 1385 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20110810/e0eaee21/attachment.bin>


More information about the LibreOffice mailing list