[Libreoffice] [REVIEW 3-4] fdo#42147: fix crash

Ivan Timofeev timofeev.i.s at gmail.com
Thu Dec 8 21:44:57 PST 2011


08.12.2011 23:36, Ivan Timofeev пишет:
> Hi there!
>
> Please review
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=dc61ebdc93a777f4f41c1ae837bdb6098ecffcce
>
> and push to 3-4 if the commit is ok for you.
>
> It seems, due to wrong condition (using & instead of ==) the code casted
> SwCntntNode to SwTxtNode, but the SwCntntNode is a base class of the
> SwTxtNode.
>
> Thanks,
> Ivan

Oh no, wait, I was getting all mixed up :(
This is not a fix for the mentioned bug, the proper fix was
http://cgit.freedesktop.org/libreoffice/core/commit/?id=3524727db0f3cfecf3a47046795c527808c10c3e
which is now backported to 3-4.

Heh, excuse my having done so! I tested the bug with master and there 
was a crash, but after my patch there was not. Then I lost my sanity and 
went wrong way...

Sorry once again,
Ivan


More information about the LibreOffice mailing list